Draft
Conversation
…tion within verifytypes
- Wrap git steps in _run_git helper that captures stderr (previously stderr was merged into stdout and piped to DEVNULL, hiding failures). - Capture and log stdout/stderr from the 'pip install .' step of the main-branch install; raise CalledProcessError on failure so real install errors surface as a CI failure instead of being treated as 'package not in main, skip'. - Add --no-deps to the main-branch install so pyright sees the same dependency closure for both type-completeness runs, isolating the comparison to changes in the package itself. - Use as_posix() for the sparse-checkout path. Relates to Azure#46426. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When pyright --verifytypes completes but produces empty output, the common root cause is that the installed package is missing namespace __init__.py files or was installed to an unexpected location — pyright finds zero symbols and exits 1 silently. Add a _log_installed_package_layout helper that runs 'pip show -f' for the distribution and walks the on-disk module directory via importlib.util.find_spec. This makes the empty-pyright-output case diagnosable from CI logs without having to reproduce locally. Relates to Azure#46426. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.