[Python] TypeSpec migration for azure-mgmt-monitor#46407
Draft
ChenxiJiang333 wants to merge 3 commits intoAzure:mainfrom
Draft
[Python] TypeSpec migration for azure-mgmt-monitor#46407ChenxiJiang333 wants to merge 3 commits intoAzure:mainfrom
ChenxiJiang333 wants to merge 3 commits intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Python] TypeSpec migration for azure-mgmt-monitor
Spec source
Spec PR: Azure/azure-rest-api-specs#42199
Pre-migration swagger source
specification/monitor/resource-manager@0136b7fc
Swagger API version
Default tag
package-preview-2023-09contains multiple API versions:2015-04-01/2016-03-01/2018-03-01/2018-11-27-preview/2019-03-01/2020-10-01/2021-05-01-preview/2021-07-01-preview/2022-10-01/2023-03-11/2023-04-03/2023-05-01-preview/2023-09-01-preview/2023-12-01/2024-02-01Breaking Change Analysis
All 15 breaking changes classified as ACCEPT — no mitigations needed.
The vast majority of breaking changes stem from a scope difference: the old swagger tag
package-preview-2023-09bundled manyMicrosoft.InsightsAPIs (action groups, tenant action groups, metrics, autoscale, etc.), while this TypeSpec (Microsoft.Monitor.Management) only coversAzureMonitorWorkspaceandPipelineGroupresources.Classification Summary
tenant_action_groupssubscription_idin__init__ErrorResponselostcode/messagevarsActionGroupPatchBodyAzureAppPushReceiverAzureResourceEmailReceiverReceiverStatusSmsReceiverTenantActionGroupListTenantActionGroupResourceVoiceReceiverWebhookReceiverTenantActionGroupsOperationsAccepted Breaking Changes (will remain)
All breaking changes are accepted:
Microsoft.InsightsAPIs (tenant action groups, action group receivers, etc.) are not covered by theMicrosoft.Monitor.ManagementTypeSpec. These APIs should be migrated separately under their own TypeSpec.ErrorResponsenow uses ARM common types v4 error structure.subscription_idis a required parameter for ARM management clients.AzureResourcebase class replaced by ARM common types.TenantActionGroupListwrapper model removed per TypeSpec convention.Spec mitigation PR
No mitigations needed — no spec PR created.