Skip to content

Add command stubs for init, new, start, pack with project detection#4858

Open
liliankasem wants to merge 1 commit intovnextfrom
feature/command-stubs
Open

Add command stubs for init, new, start, pack with project detection#4858
liliankasem wants to merge 1 commit intovnextfrom
feature/command-stubs

Conversation

@liliankasem
Copy link
Copy Markdown
Member

Register init, new, start, and pack commands with their CLI options. Commands display workload install guidance until workloads are available. Includes ProjectDetector for runtime detection from project files. 47 tests passing.

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Register init, new, start, and pack commands with their CLI options.
Commands display workload install guidance until workloads are available.
Includes ProjectDetector for runtime detection from project files.
47 tests passing.

/// <summary>
/// Launches the Azure Functions host runtime. Supports 'func start' and
/// Placeholder for 'func start' (not yet implemented).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by this comment - supports func start and placeholder for func start? What is this placeholder?

_interaction.WriteMarkupLine(
"[grey]Install a workload to initialize a project:[/]");
_interaction.WriteBlankLine();
_interaction.WriteMarkupLine(" [white]func workload install dotnet[/] [grey]C#, F#[/]");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we store a map of worker to language options? i see this is being reused here and in newCommand so it would be nice to have a central map so we it's easy to add new workers in the future too


private readonly IInteractionService _interaction;

public PackCommand(IInteractionService interaction)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this design, how are we accounting for different subcommands (like --skip-install for node)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants