fix(knowledge-designer): Hiding the knowledge hub parameter from new designer#9082
fix(knowledge-designer): Hiding the knowledge hub parameter from new designer#9082preetriti1 wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Logic Apps designer UX to hide the Knowledge Hub/Knowledge Base parameter in the new (v2) designer, while also updating “Learn more” links in Knowledge Hub UI surfaces.
Changes:
- Hide parameters with editor type
knowledgebasefrom the v2 designer parameter list (toParameterInfoMap). - Update Knowledge Hub “Learn more” links to a single fwlink URL in multiple UI locations.
- Add unit tests validating that
knowledgebaseeditor parameters are excluded fromtoParameterInfoMap.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/designer/src/lib/ui/knowledge/panel/files/uploadfile.tsx | Updates “Learn more” links in the Knowledge Hub file upload panel sections. |
| libs/designer/src/lib/ui/knowledge/editor/index.tsx | Updates the Knowledge Hub editor “Learn more” link URL. |
| libs/designer-v2/src/lib/core/utils/parameters/helper.ts | Filters out knowledgebase editor parameters when generating v2 parameter infos. |
| libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.spec.ts | Adds tests ensuring knowledgebase editor parameters are excluded. |
| for (const inputParameter of inputParameters) { | ||
| if (!inputParameter.dynamicSchema) { | ||
| if (!inputParameter.dynamicSchema && !equals(inputParameter.editor, 'knowledgebase')) { | ||
| const parameter = createParameterInfo(inputParameter, metadata, shouldEncodeBasedOnMetadata); |
There was a problem hiding this comment.
toParameterInfoMap is using a raw string literal 'knowledgebase' for the editor check, but this file otherwise relies on constants.EDITOR.* for editor comparisons. Consider adding a KNOWLEDGE_BASE entry to libs/designer-v2/src/lib/common/constants.ts and referencing it here (or reusing the shared designer-ui constant) to avoid typos/drift and keep editor handling consistent.
There was a problem hiding this comment.
This is just point in time, till we fix the new designer to host knowledge hub ui properly.
| description={INTL_TEXT.addFilesSectionDescription} | ||
| descriptionLink={{ text: INTL_TEXT.learnMore, href: 'https://www.microsoft.com' }} | ||
| descriptionLink={{ text: INTL_TEXT.learnMore, href: 'https://go.microsoft.com/fwlink/?linkid=2361415' }} | ||
| items={addSectionItems} |
There was a problem hiding this comment.
This Learn More URL is duplicated (also used in the earlier TemplatesSection). Consider extracting it to a single constant (or INTL_TEXT entry) so future link updates only need to be made once.
There was a problem hiding this comment.
Still waiting for new links from @divyaswarnkar
📊 Coverage CheckThe following changed files need attention:
Please add tests for the uncovered files before merging. |
Commit Type
Risk Level
What & Why
Hiding the newly added knowledge hub parameter from agent connector in new designer. This should not impact anything in current GA designer for this new feature to be released.
Also updated the learn more links from 3 places in knowledge hub UI
Impact of Change
Test Plan
Contributors
@divyaswarnkar
Screenshots/Videos
in V2
Before:
After:
