Repository navigation
Call npm.cmd on Windows in Export-AdfToArmTemplate #462 - #515
Merged
Merged
Conversation
On Windows, 'npm' runs npm.ps1, which in some npm versions reads $MyInvocation.Statement under strict mode and fails on Windows PowerShell 5.1 (windows-2025 agents). npm.cmd skips npm.ps1. A failed npm command now stops the export instead of being ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #462
Root cause
Export-AdfToArmTemplatecalled a barenpm, so on Windows PowerShell runs thenpm.ps1script that Node installs. Some npm versions'npm.ps1setsSet-StrictMode -Version Latestand reads$MyInvocation.Statement, which only exists in PowerShell 7.4+. On Windows PowerShell 5.1 (thewindows-2025agents) this throwsThe property 'Statement' cannot be found on this object.Changes
Invoke-AdfNpm(private/Invoke-AdfNpm.ps1): callsnpm.cmdon Windows (skipsnpm.ps1) andnpmelsewhere.npm iornpm run build exportstops the export instead of being ignored.[Unreleased].Tests
test/Export-AdfToArmTemplate-Npm.Tests.ps1(which npm command is chosen, argument passing, failure on a non-zero exit code, the three npm calls of the export). They pass locally under both$ErrorActionPreference = 'Continue'and'Stop'.Export-AdfToArmTemplate.Tests.ps1runs real npm and is verified by this PR's CI run.🤖 Generated with Claude Code