Skip to content

Add CLAUDE.md rules learned from recent issues - #511

Merged
NowinskiK merged 1 commit into
developfrom
claude-md-rules
Oct 16, 2026
Merged

NowinskiK merged 1 commit into
developfrom
claude-md-rules

Conversation

@NowinskiK

Copy link
Copy Markdown
Member

Adds project rules to CLAUDE.md, based on what we ran into while working on #404, #435 (#507, #508), #295 and the 1.19.0 release. No code changes.

New sections

  • Branches and releases: feature branches from develop and PRs into develop, never straight into master (Fix unit tests for Pester 6 and VS Code host #501 #502 was). Release via develop → master, then move develop to master. Version and ModuleVersion are set at release; feature PRs use [Unreleased].
  • Issues and PRs: comment root cause and approach on the issue before coding, create sub-issues for independent problems, Closes #n in PRs.
  • Error handling (Az cmdlets): Az cmdlets write non-terminating errors, so always -ErrorAction Stop inside try. Retry only temporary errors with Invoke-AdfWithRetry. Validation belongs in Test-AdfCode. A failed object deployment stops the publish; a failed trigger start/stop is a warning.
  • PowerShell strict mode: missing properties and $null.Count throw; if assignments unroll arrays.

Added to existing sections

  • Changelog: a behaviour change counts as a functional change (the Unit tests fail with Pester 6 and in VS Code host #501 change had no entry).
  • Tests: bug fixes start with a failing test; Az mocks must Write-Error, not throw; run tests under both Stop and Continue; deployment tests cover both publish methods.

🤖 Generated with Claude Code

Branching/release flow, issue workflow, Az error handling, strict mode
pitfalls and test conventions (tests first for bug fixes, Write-Error
mocks, both ErrorActionPreference values, both publish methods).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NowinskiK
NowinskiK merged commit b639e32 into develop Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant