Repository navigation
Sync master into develop and require Pester 6.0+ #501 - #506
Merged
Merged
Conversation
Fixed ClientAssertionCredential authentication failure for federated identity (OIDC) credentials by removing redundant `Get-AzAccessToken` calls in `Get-AzDFV2Credential` and `Remove-AdfObjectRestAPI` #492
Implement CI/CD improvements and update module versions
…host #501 Removed dependency on $psEditor.GetEditorContext(), which throws in VS Code host when the active tab is not a file on disk. Also fixes ConsoleHost path pointing to TestHelper folder instead of test folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ADFT0026 was reported via Write-Error (non-terminating), so whether it failed depended on the caller's $ErrorActionPreference, making PublishOption.Tests.ps1 order-dependent. Use throw, consistent with #472. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fix unit tests for Pester 6 and VS Code host #501
CI runners ship Pester 5.x only, so tests silently ran on 5.9.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#501 Same cause as the disabled test in Publish-AdfV2FromJson-1.Tests.ps1: user-assigned MI 'adftoolstest1' is not associated with the test factory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
developin line withmasterand makes Pester 6 a hard requirement, so the release PR #505 can pass.Why
#502 (issue #501) was merged straight into
master, sodevelopnever got its fixes: Pester 6 syntax,Get-RootPathfix, the disabledcredential1test. #505 (develop → master) was therefore still running the credential test and failing.Changes
masterintodevelop(Fix unit tests for Pester 6 and VS Code host #501 #502). Clean merge, no conflicts.test/!RunAllTests.ps1: installs Pester 6 from PSGallery when only an older version is available (GitHub runners ship Pester 5.x, so CI was silently running 5.9.0), unloads older Pester, imports-MinimumVersion 6.0.0.CLAUDE.mdupdated to match.credential1setup and test inRemove-AdfObjectRestAPI.Tests.ps1: it deployscredential1while Pester loads the file and fails withInvalidUserAssignedMiCredential(user-assigned MIadftoolstest1not associated with the test factory), the same cause as the test disabled in Unit tests fail with Pester 6 and in VS Code host #501.Should existstill runs.New-AdfPublishOptionchange from Unit tests fail with Pester 6 and in VS Code host #501.Testing
Stop-Trigger,Start-Trigger,PublishOptiontests, 31/31 passed.Assert-MockCalledleft in any test file.Follow-up
Associate MI
adftoolstest1with factoryadf2-7d6cdb5fagain (or have the tests set it up), then re-enable both credential tests.🤖 Generated with Claude Code