Repository navigation
Exclude expired event markets from cached basket quotes - #3
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Discovery caches markets for 15 seconds and sentiment for 10 seconds. A market can expire during either TTL or during order-book reads, leaving an expired probability in the basket and stale time remaining in the UI.
Fix
Filter cached discovery results by current expiry and recalculate countdowns. Recompute cached sentiment when any constituent expires; discard markets that expire during order-book reads. Recheck expiry at basket pricing and prevent aggregate sentiment from resurrecting an expired window. Document that this only addresses event expiry, not upstream feed freshness.
Verification
New deterministic regressions cover cached expiry, countdown refresh, aggregate recomputation, expiry during order-book reads and explicit/implicit basket fallback.
npm test: 42/42 pass.git diff --checkpasses. Independent scoped review found no important issue.No live feed quality or trading profitability claim.