Repository navigation
Fix basket quotes that silently substitute the requested event window - #1
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request for 60-minute basket legs could select 5-minute markets when the requested window was absent and still return a successful adjusted quote.
This change requires priced marginals for the explicit interval, returns insufficient_data when either is missing, and returns independence_only when the correlation interval differs. It adds engine CI and documents these semantics.
Validation: reproduced the original behavior; all six new regressions failed before the fix; npm test now passes 35/35. Tests are deterministic and do not establish live market-data availability. No production deployment is included.