feat(Notifications): add option to disable popup background fill#2708
Open
A1ca7raz wants to merge 1 commit into
Open
feat(Notifications): add option to disable popup background fill#2708A1ca7raz wants to merge 1 commit into
A1ca7raz wants to merge 1 commit into
Conversation
- New "Disable Background Fill" toggle in Settings > Notifications - Adds notificationPopupBgDisabled setting (default off) - Popup renders transparent fill in connected frame mode, keeping blur/border - Toggle only visible when Connected Frame Mode is active
This comment was marked as spam.
This comment was marked as spam.
bbedward
requested changes
Jun 29, 2026
| visible: SettingsData.connectedFrameModeActive | ||
| tags: ["notification", "popup", "background", "color", "fill", "transparent", "blur"] | ||
| text: I18n.tr("Disable Background Fill") | ||
| description: I18n.tr("Render notification popups with no fill color, letting blur and border show through.") |
Collaborator
There was a problem hiding this comment.
Prefer to remove the description for less translation burden, maybe instead show a test notification like changing the position does - which makes it clear whats different from the setting
bbedward
reviewed
Jun 29, 2026
| targetRadius: win.connectedFrameMode ? Theme.connectedSurfaceRadius : Theme.cornerRadius | ||
| targetColor: win.connectedFrameMode ? Theme.floatingSurface : Theme.readableSurface | ||
| targetColor: (win.connectedFrameMode && SettingsData.notificationPopupBgDisabled) | ||
| ? "transparent" |
Collaborator
There was a problem hiding this comment.
Should also use Theme.withAlpha... instead of "transparent"
Collaborator
|
This is also equivalent to this setting albeit, that one applies to multiple surfaces and isnt targeted to notifications only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a "Disable Background Fill" toggle (Connected Frame Mode only) that makes notification popups render with a transparent fill for a more seamless, glass-like integration with the shell.
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings