Fix Playground command response materialization - #2245
Merged
Conversation
Snapshot response text while crossing the Playground runtime boundary so proxy-backed values cannot mutate before plugin-state consumers parse them. AI assistance: OpenAI gpt-5.6-sol via OpenCode diagnosed the lazy response boundary, implemented the materialization fix and regression, and ran the focused test, build, typecheck, and diff checks. Chris Huber reviewed and owns the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlaygroundRunResponse.textwhile crossing the runtime boundary.Fixes #2236.
Verification
npm exec -- tsx tests/plugin-state-command.test.tsnpm run buildnode ./node_modules/typescript/bin/tsc -b --pretty falsegit diff --checkAI assistance
OpenAI gpt-5.6-sol via OpenCode diagnosed the lazy runtime response boundary, implemented the focused materialization fix and regression, and ran the verification commands. Chris Huber reviewed and owns the change.