Move the canFeature policy out of the Activity vocabulary layer

[pfefferle]

Proposed changes:

• Activity classes are generic vocabulary and must not contain application logic. The FEP-7aa9 canFeature computation (driven by the activitypub_default_feature_policy site option) moves out of Activity\Actor directly into the User and Blog models, each computing the policy fresh and merging with an explicitly set interaction policy only when one is present.
• A shared model-layer trait was considered and discarded during review: its implicit requirements on the using class (inherited accessor, actor methods) made it too easy to use incorrectly, so the two models intentionally carry the implementation themselves.
• This also fixes two behavior leaks:
  • Activity\Actor represents remote actors too — the old override injected the local site's canFeature policy into foreign actor representations on re-serialization. Generic actors now fall back to the plain property accessor.
  • The Application actor no longer advertises a consent policy at all (per FEP-7aa9, absence of policy means no consent), matching its role as a system actor.

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• Run the interaction policy tests: npm run env-test -- --filter Test_Interaction_Policy — the four pre-existing model tests pass unchanged, plus two new ones covering the generic-actor and Application-actor behavior.
• Fetch an author or blog profile with an ActivityPub Accept header and confirm interactionPolicy.canFeature still reflects the Default Starter Kit policy setting.
• Fetch the Application actor profile and confirm it carries no interactionPolicy.

[Copilot]

Pull request overview

This PR moves FEP-7aa9 interactionPolicy.canFeature computation out of the generic Activity vocabulary layer and into the model layer, so that only local actors (blog/author) advertise the site’s consent policy while remote and system actors do not.

Changes:

• Introduces a model-layer Interaction_Policy trait and applies it to the User and Blog models.
• Removes the interaction policy computation from Activity\Actor to prevent leaking local policy into remote actor re-serialization.
• Adds/extends PHPUnit coverage for generic actors and the Application actor behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/phpunit/tests/includes/model/class-test-interaction-policy.php	Adds tests ensuring generic actors don’t emit local policy and Application emits no interactionPolicy.
includes/model/trait-interaction-policy.php	New trait that computes canFeature from the activitypub_default_feature_policy option for local actors.
includes/model/class-user.php	Applies the new interaction policy trait so user actors still emit canFeature.
includes/model/class-blog.php	Applies the new interaction policy trait so blog actors still emit canFeature.
includes/activity/class-actor.php	Removes policy computation from the vocabulary-layer actor to avoid app-logic leakage to remote actors/system actor.
.github/changelog/update-move-interaction-policy-to-models	Adds a patch changelog entry describing the behavior change.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.