Skip to content

fix(web): route contest notification inbox rows to Contest page#14402

Merged
dylanjeffers merged 1 commit into
mainfrom
fix/web-contest-notification-inbox-row
May 26, 2026
Merged

fix(web): route contest notification inbox rows to Contest page#14402
dylanjeffers merged 1 commit into
mainfrom
fix/web-contest-notification-inbox-row

Conversation

@dylanjeffers
Copy link
Copy Markdown
Contributor

Summary

  • The 7 remix contest notification tiles in packages/web/src/components/notification/Notification/ dispatched push(getEntityLink(entity)), which navigates to the Track page instead of the Contest page.
  • Mirrors the working pattern from RemixContestUpdateNotification.tsx and replaces getEntityLink(entity) with contestPage(entity.permalink) in each file.
  • Companion to the mobile fix in Fix artist spotlight card name truncation #14400 (fix/mobile-contest-notification-inbox-row).

Files updated:

  • FanRemixContestStartedNotification.tsx
  • FanRemixContestEndedNotification.tsx
  • FanRemixContestEndingSoonNotification.tsx
  • FanRemixContestWinnersSelectedNotification.tsx
  • ArtistRemixContestEndedNotification.tsx
  • ArtistRemixContestEndingSoonNotification.tsx
  • ArtistRemixContestSubmissionsNotification.tsx

Test plan

  • eslint clean on all 7 files
  • tsc --noEmit clean for packages/web
  • Manually click each contest notification type in the inbox and confirm it lands on the contest page (not the track page). Note: this requires triggering real contest notifications, so it wasn't exercised against the local dev server.

🤖 Generated with Claude Code

The 7 remix contest notification tiles dispatched
`push(getEntityLink(entity))`, which sends the user to the Track page
instead of the contest. Mirror the working pattern from
RemixContestUpdateNotification and route to `contestPage(permalink)`.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 26, 2026

⚠️ No Changeset found

Latest commit: e65e665

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14402.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

@dylanjeffers dylanjeffers merged commit cdb23c1 into main May 26, 2026
13 checks passed
@dylanjeffers dylanjeffers deleted the fix/web-contest-notification-inbox-row branch May 26, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant