Skip to content

Build(#80): Prerules and workflow update - #81

Merged
andybeet merged 5 commits into
feature/i38-rlinkfrom
build/i80-prerules-workflow-update
Sep 18, 2026
Merged

andybeet merged 5 commits into
feature/i38-rlinkfrom
build/i80-prerules-workflow-update

Conversation

@andybeet

@andybeet andybeet commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Justification

It appears that ubuntu 18.04 is at EOL. This, i think, is the reason the workflow is failing because the model wont compile due to a missing file from a package that was by default part of the OS image. It may have been archived. So an update to a more recent version of abuntu is required -> 20.04. As a safeguard the previously bundled package is not being explicitly installed (r-base-dev). In addition some of the PreRules.am conditional logic is incorrect. This has been fixed

Fixes #80

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Further comments

If this is a New Feature, Breaking change, or a bug fix, the Atlantis Manual will need to be updated to reflect these changes.
Now would be a good time to create an issue in the Atlantis Manual repo and begin documenting your changes.

  • I've created an issue
  • This is NA

Reviewer instructions:

Assign at least 2 reviewers:

If SETAS_example workflow passes then that is all that needs to be reviewed. EDIT: just realized that the workflow will only run on PRs to dev. However, could you pull the branch and make sure it still compiles and builds for you?

@andybeet
andybeet changed the base branch from main to feature/i38-rlink September 10, 2026 15:45
@andybeet
andybeet marked this pull request as draft September 10, 2026 15:54
@andybeet
andybeet marked this pull request as ready for review September 10, 2026 15:54
@andybeet
andybeet requested a review from erlasturl September 14, 2026 18:06
@andybeet

andybeet commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

@erlasturl This is just a fix to allow the built in workflow to run, but it would be good to know if you can build the model from this branch. I have tested it, and can build it both on ubuntu 18.04 and 20.04 (in a docker container)

@erlasturl erlasturl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to compile the code on our docker and the Rlink worked

@andybeet

Copy link
Copy Markdown
Collaborator Author

@erlasturl Great!! this should fix the broken workflow on the other branch. i hope! 🤞

@andybeet
andybeet merged commit e985b69 into feature/i38-rlink Sep 18, 2026
1 check passed
@andybeet
andybeet deleted the build/i80-prerules-workflow-update branch September 18, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build: Workflow using EOL ubuntu 18.04

2 participants