Build(#80): Prerules and workflow update - #81
Merged
Merged
Conversation
andybeet
marked this pull request as draft
September 10, 2026 15:54
andybeet
marked this pull request as ready for review
September 10, 2026 15:54
Collaborator
Author
|
@erlasturl This is just a fix to allow the built in workflow to run, but it would be good to know if you can build the model from this branch. I have tested it, and can build it both on ubuntu 18.04 and 20.04 (in a docker container) |
erlasturl
approved these changes
Sep 18, 2026
erlasturl
left a comment
Collaborator
There was a problem hiding this comment.
I was able to compile the code on our docker and the Rlink worked
Collaborator
Author
|
@erlasturl Great!! this should fix the broken workflow on the other branch. i hope! 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
It appears that ubuntu 18.04 is at EOL. This, i think, is the reason the workflow is failing because the model wont compile due to a missing file from a package that was by default part of the OS image. It may have been archived. So an update to a more recent version of abuntu is required -> 20.04. As a safeguard the previously bundled package is not being explicitly installed (
r-base-dev). In addition some of the PreRules.am conditional logic is incorrect. This has been fixedFixes #80
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyFurther comments
If this is a New Feature, Breaking change, or a bug fix, the Atlantis Manual will need to be updated to reflect these changes.
Now would be a good time to create an issue in the Atlantis Manual repo and begin documenting your changes.
Reviewer instructions:
Assign at least 2 reviewers:
If
SETAS_exampleworkflow passes then that is all that needs to be reviewed. EDIT: just realized that the workflow will only run on PRs to dev. However, could you pull the branch and make sure it still compiles and builds for you?