Skip to content

Add E2B sandbox support and paged file reads - #352

Merged
mintuhouse merged 2 commits into
mainfrom
mintuhouse/tanstack-sandbox-1
Oct 23, 2026
Merged

mintuhouse merged 2 commits into
mainfrom
mintuhouse/tanstack-sandbox-1

Conversation

@mintuhouse

Copy link
Copy Markdown
Contributor
  • Add E2B through its maintained adapter, using an organization template and encrypted API key in the existing sandbox configuration and agent assignment flows.
  • Page sandbox_read_file through the public workspace backend with line offsets, up to 2,000 lines per page, and the existing 40,000-character limit.
  • Keep sandbox leases, command behavior, and durable artifact downloads while covering credential isolation, paging, truncation, and cancellation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T17:01:45.006041Z 43e3dd1 New commits
🔒 Security Review ✅ Completed 2026-10-23T09:09:48.407579Z fd9f8e5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

mintuhouse commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Validation results

Head: 43e3dd1a34700117467b67da96f4bcefcb60c85a

Rebased onto main f200d41f9055e8967102da2d8f9b4b5c5e529a72. Application and test changes are preserved. The two documentation conflicts retain main's lifecycle guidance plus E2B and paging details.

  • Setup, migration, seeding, and SDK build passed.
  • Focused sandbox tests, Platform build, hosted checks/reviews, and both browser suites are running for this head.
  • The Platform browser suite uses a command-line 600-second test budget, matching the journey's existing budget and avoiding the previously diagnosed 30-second multi-step usage-limit timeout. No test code changed.
Earlier validation and unchanged UI walkthrough

Validation results

Head: fd2297abbbbdb2d619940b0ea029fb77a8739d33

This follow-up replaces the custom sandbox path normalization loop with node:path.posix.resolve, preserves virtual workspace mapping and containment checks, and pins experimental @tanstack/ai-harness to 0.1.0. It removes 12 net lines. Compaction is outside this change.

Check Result
Hosted checks All 11 currently reported checks passed for this head
Focused sandbox tests 17 passed across path resolution and sandbox tool tests
Formatting and type-aware lint Passed
Frozen-lockfile install Passed, with no dependency version changes
Platform and SDK builds Passed
Binary smoke Passed with a disposable database, removed afterward
Todos deterministic browser suite 66 passed in 5.0m
Platform browser suite 13 passed, 1 usage-limit flow exceeded its 30-second test timeout in a 7.1m run
Focused Platform rerun 4 passed in 4.4m, including preflight, the dashboard journey, and the usage-limit flow, with a command-line 180-second timeout

The original usage-limit trace contained only a test timeout. Every step completed, and the final page showed the expected deletion confirmation and remaining rows. The focused rerun changed only the command-line timeout. No usage-limit source or test code changed. The original report and trace were preserved outside the worktree before the rerun.

Current local reports: platform/e2e/.output/report/index.html (focused rerun) and examples/todos/e2e/.output/report/index.html (66-test suite). Original Platform suite evidence: /tmp/astralbeam-harness-evaluation-J91hcF/platform-browser-first-run/report/index.html.

Live E2B remains unverified without an organization API key. The earlier live paging/download check was blocked before sandbox execution by the seeded OpenAI connection's invalid_api_key. Neither external check is counted as passing.

The new commit is unsigned because signing was unavailable in this session. Signing configuration was not changed.

Previous head validation and unchanged E2B UI walkthrough

Validation results

Head: fd9f8e57ed8a2a64874455d0539d3d8ad6c4b665

Check Result
Hosted checks All 12 passed, including Platform unit/integration tests, builds, and security reviewer
Platform browser suite 14 passed in 6.5m
Todos deterministic browser suite 66 passed in 5.0m
E2B form browser check 2 passed, including sign-in setup, in 1.9m
Local Platform checks Formatting, OpenAPI freshness, lint/types, and Knip passed
Local Platform tests 680 passed, 2 skipped, 2 email-delivery test timeouts; all 6 email-delivery tests passed on an isolated rerun without code changes
Builds Platform, SDK, and Todos passed
Todos checks/unit tests Checks passed, 3 tests passed
Binary smoke Passed with a disposable database before the test-only simplification; production code unchanged

Codex code and security reviews completed with no findings for this head.

The E2B form check verifies the base template default, a masked API key, and clearing credentials when switching providers. Paging, virtual workspace paths, empty files, long-line truncation, cancellation, credential isolation, and failed cleanup passed in local tests.

The live paging/download browser check was blocked before sandbox execution because the seeded OpenAI provider rejected its API key (invalid_api_key). Live E2B remains unverified without an organization API key. These external checks are not counted as passing.

Local browser reports: platform/e2e/.output/report/index.html and examples/todos/e2e/.output/report/index.html. The live paging failure report was retained separately outside the worktree.

E2B setup walkthrough

Template defaults, masked API key, and credential clearing when switching providers. The recording uses disposable seeded data and a synthetic key.

walkthrough.webm

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
www-astralbeam-ai 43e3dd1 Commit Preview URL

Branch Preview URL
Oct 23 2026, 05:03 PM

@mintuhouse

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fd2297a. Configure here.

@mintuhouse
mintuhouse force-pushed the mintuhouse/tanstack-sandbox-1 branch from fd2297a to 43e3dd1 Compare October 23, 2026 17:01
@mintuhouse
mintuhouse merged commit 9b53c92 into main Oct 23, 2026
11 checks passed
@mintuhouse
mintuhouse deleted the mintuhouse/tanstack-sandbox-1 branch October 23, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant