Skip to content

Preserve model price history and schedule rate changes - #349

Open
mintuhouse wants to merge 2 commits into
mainfrom
mintuhouse/request-pricing-snapshots
Open

mintuhouse wants to merge 2 commits into
mainfrom
mintuhouse/request-pricing-snapshots

Conversation

@mintuhouse

Copy link
Copy Markdown
Contributor
  • Preserve manual model price history and schedule future USD rates through the existing provider editor. Current changes create immutable versions. Future entries can be edited or cancelled, and restoring catalog defaults cancels scheduled overrides.
  • Resolve prices at each upstream request's start and persist a credential-free rate snapshot before dispatch. Apply the same request costs to saved history and spend limits, including native-web continuations, while preserving authorization, writer fencing and prompt cancellation.
  • Add JSONB columns to existing model and message records. Initialize existing manual rates at migration time without inventing earlier prices.
  • Match binary smoke testing to the documented five-second HTTP drain plus five-second resource cleanup budget.
  • Follow up usage totals #342. Partial-usage recovery, recorded-cost summary columns and incompleteness reporting remain in the saved plan. Missing costs continue to count as zero for now.
  • Walkthrough: Schedule, edit and cancel future model prices, with viewer access denied

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T08:52:50.594488Z 59b0592 New commits
🔒 Security Review ✅ Completed 2026-10-22T20:00:28.505519Z c5dc876 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mintuhouse

mintuhouse commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Validation results for 59b0592641c5bb53fa863cd00b2cb68094dd2936

  • Rebased on main 334195c3d, including TanStack AI v1 and the 0.22.0 release bump. Preserved the failed-usage accounting and cache-pricing changes from main.
  • Thorough review fixed scheduled-price activation during a blocked save and made Reload latest reset stale editor state. Added database and browser regressions. Removed the redundant startup pricing lookup.
  • Local focused tests: 70 unit tests and 43 PostgreSQL integration tests passed. Integration used a fresh disposable database and all checked-in migrations. Platform checks passed, including formatting, OpenAPI, lint/type checks and Knip.
  • Seeded browser flow: 2 tests passed in 2.1 minutes. Covers schedule/edit/cancel, desktop/mobile, viewer denial, activation conflict recovery and successful save afterward. Evidence retained outside the worktree at /tmp/pr349-rebase-review-20261023/seeded-evidence.
  • Production build passed, including all 33 docs prerenders. SDK 0.22.0 build passed. Final binary smoke passed with clean SIGTERM shutdown.
  • Post-push Platform default browser suite: 14 passed in 6.8 minutes. Report: platform/e2e/.output/report.
  • Post-push Todos app browser suite: 65 passed and 1 failed in 4.7 minutes. The unchanged cancellation test again failed during teardown with json: Response has been disposed at examples/todos/e2e/specs/app/directory-cache.spec.ts:207. Its trace matches the prior-head failure; this PR has no SDK or Todos diff against main. Left this unrelated harness issue out of the pricing changes. Report: examples/todos/e2e/.output/report.
  • Hosted CI: all 11 reported checks passed on this head, including full Platform unit/integration tests and build. No actionable GitHub review threads are present. Cursor completed its requested review of the prior head with no findings; no completed automated review of this new head has been reported.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
www-astralbeam-ai 59b0592 Commit Preview URL

Branch Preview URL
Oct 23 2026, 08:53 AM

@mintuhouse

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c5dc876. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant