Skip to content

Harden MCP authorization and tool execution lifetimes - #337

Merged
mintuhouse merged 9 commits into
mainfrom
codex/security-remediation-followup
Oct 22, 2026
Merged

mintuhouse merged 9 commits into
mainfrom
codex/security-remediation-followup

Conversation

@mintuhouse

@mintuhouse mintuhouse commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
  • Bind OAuth client credentials to their authorization server issuer for every provider, following the MCP issuer-binding contract. Pre-registered applications now require an administrator-supplied trusted issuer. Older definitions without one must be removed and added again, and unbound connections require reauthorization.
  • Recheck host-tool authority after asynchronous validation, including Stop, session changes and tool replacement. Preserve these guards when integrating the tool-contract changes in #273.
  • Authorize chat response targets before evaluating output schemas and retain preview capacity until native rendering settles.
  • Isolate RustFS installer downloads and omit storage credentials from startup tracing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T18:16:26.432573Z e713c63 New commits
🔒 Security Review ✅ Completed 2026-10-20T19:33:25.522242Z c71c115 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mintuhouse

mintuhouse commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Validation results for e713c63c7ece5b937953e0ec00c40e328f0c0f43

  • Rebased onto latest main (373aa29b8, tenant-user usage by period). All nine PR commits have identical patches according to git range-diff; no conflicts or new source edits. Remote head and base verified, PR mergeable, worktree clean.
  • Re-ran repository setup, Platform/SDK checks, and 102 focused tests across chat commands, PostgreSQL conversations, streaming and HTTP transport: all passed. Production build passed in 26.9 seconds and native binary smoke passed in 11.5 seconds against a dedicated disposable bootstrap database.
  • Current-head full browser suites passed: Platform 14/14 in 366.0 seconds wall time; Todos app 66/66 in 295.1 seconds. Reports: platform/e2e/.output/report/index.html and examples/todos/e2e/.output/report/index.html.
  • Current-head hosted CI: all ten jobs passed on this exact commit, plus the Workers build.
  • Final local diff review and git diff --check passed. All existing review threads remain resolved. Disposable test databases were removed. The PR was subsequently squash-merged as 8c45fee49947081becd001d0a7414d9021b472a4 after the final checks below.
  • Final merge review: no actionable findings. Verified the exact reviewed head, all eleven passing checks (ten CI jobs plus Workers), all three resolved review threads, and the current-head automated code review with no findings. Main advanced to 4802666c7 during review; a temporary local merge proved the PR diff unchanged on that base. The exact combined tree (bc2797c69287e53b93ef2039a692e5921197efd8) passed Platform checks and 166 focused chat, sandbox, OAuth, HTTP and preview tests (one parent-run worker helper skipped, exercised in child processes). The temporary merge was aborted and the disposable database removed before the SHA-guarded GitHub merge. GitHub confirms the PR is merged. Evidence: /Users/mintuhouse/security-audit-skill/astralbeam/final-merge-review-337-20261022-235620/.
  • Prior head fb36adbe2: all hosted checks passed after rerunning only the integration job, whose first attempt hit ECONNREFUSED waiting for the unchanged operator-configuration test's local Vite server. Local Platform 14/14 and Todos 66/66 browser tests passed on that head.
  • Earlier feature evidence remains scoped to unchanged paths: controlled local OAuth fixtures covered automatic/CIMD/pre-registered flows, callback, refresh/reconnect, issuer mismatches and secret isolation. No external provider accounts were exercised. Host-tool, preview-capacity, setup/install and negative-control evidence is retained. No issuer UX change or MCP query cleanup is included in this rebase.
  • Current evidence: /Users/mintuhouse/security-audit-skill/astralbeam/rebase-337-20261022-234310/. Earlier feature evidence: /Users/mintuhouse/security-audit-skill/astralbeam/feature-review-337-20261022-124944/.

Existing media below predates this rebase and uses disposable fixtures, including a simulated host-tool protocol.

host-tool-lifetime

host-tool-lifetime.webm

Generic OAuth issuer validation

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
www-astralbeam-ai e713c63 Commit Preview URL

Branch Preview URL
Oct 22 2026, 06:16 PM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 157a1f403a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/src/core/session.ts
@mintuhouse
mintuhouse force-pushed the codex/security-remediation-followup branch from c204898 to 5f50351 Compare October 22, 2026 09:31
@mintuhouse

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f50351. Configure here.

Comment thread sdk/src/core/agent-tools.ts
@mintuhouse
mintuhouse force-pushed the codex/security-remediation-followup branch 3 times, most recently from 5f07a64 to b599718 Compare October 22, 2026 11:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b59971848a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread platform/src/lib/storage/file-previews.server.test.ts Outdated
@mintuhouse
mintuhouse force-pushed the codex/security-remediation-followup branch from fb36adb to e713c63 Compare October 22, 2026 18:15
@mintuhouse
mintuhouse merged commit 8c45fee into main Oct 22, 2026
11 checks passed
@mintuhouse
mintuhouse deleted the codex/security-remediation-followup branch October 22, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant