You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(storage): separate COS origin and CDN delivery modes - #699
COS 源站模式此前根据是否填写 download_base_url 隐式选择默认 endpoint 或自定义下载域,导致地址字段始终展示。现在明确区分默认 COS 源站、自定义源站下载域(COS Q-Sign)和腾讯 CDN(Type D / SHA-256):默认源站隐藏并忽略休眠地址,另外两种模式显示并要求填写同一个下载地址。
保留已发布配置的行为:m20261103_000001_cos_download_delivery 只对缺少 download_delivery 且下载地址非空的 COS 配置写入 custom_origin,覆盖保存策略、远端目标及延迟清理快照。显式模式不覆盖,运行时不推断模式;支持幂等执行、事务回滚和 down 迁移。
astercommunity-automationBot
added
Documentation
Improvements or additions to documentation
Rust
Pull requests that update Rust code
TypeScript
Pull requests that update JavaScript code
Scope: Storage
Storage policies, connectors, drivers, provider capabilities, and storage backends
Scope: Admin UI
Administrator-facing frontend workflows and management interfaces
CI: Running
A pull request has required CI workflows that have not reached a terminal state
labels
Nov 3, 2026
No unresolved issue identified here blocks merging after normal checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
标题 "fix(storage): separate COS origin and CDN delivery modes" 描述了 PR 的主要变更:腾讯 COS 下载交付拆分为默认源站、自定义源站和 CDN 三种模式。变更集中也包含 negate 条件、迁移和文档,但标题聚焦于核心意图,属于相关且具体的标题。
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
PR 描述覆盖了模板的核心信息:变更内容(三种下载交付模式、negate 条件、中继优先级)、实现与升级说明(可逆迁移、文档同步)以及验证结果。但模板的 Summary 与 Test plan 复选框格式未按模板结构呈现,Notes for reviewers 中的数据库迁移、运行时配置变更字段也只以段落形式描述。作者还称 Rust 工作区测试与 Clippy 等部分结果仍在确认中,但在验证部分又…
Full details: Description check
Explanation
PR 描述覆盖了模板的核心信息:变更内容(三种下载交付模式、negate 条件、中继优先级)、实现与升级说明(可逆迁移、文档同步)以及验证结果。但模板的 Summary 与 Test plan 复选框格式未按模板结构呈现,Notes for reviewers 中的数据库迁移、运行时配置变更字段也只以段落形式描述。作者还称 Rust 工作区测试与 Clippy 等部分结果仍在确认中,但在验证部分又列出了已通过结果,二者存在不一致。
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 16 functions across 16 files. (5 skipped: 5 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ast-grep (0.51.1)
ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/kotlin/security/weak-hash-sha1-kotlin.yml
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocumentationImprovements or additions to documentationMergedPull request has been mergedRisk: HighChanges a high-risk data, security, protocol, or deployment boundaryRustPull requests that update Rust codeScope: Admin UIAdministrator-facing frontend workflows and management interfacesScope: StorageStorage policies, connectors, drivers, provider capabilities, and storage backendsTypeScriptPull requests that update JavaScript code
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COS 源站模式此前根据是否填写
download_base_url隐式选择默认 endpoint 或自定义下载域,导致地址字段始终展示。现在明确区分默认 COS 源站、自定义源站下载域(COS Q-Sign)和腾讯 CDN(Type D / SHA-256):默认源站隐藏并忽略休眠地址,另外两种模式显示并要求填写同一个下载地址。下载策略仍优先:
relay_stream覆盖交付模式并保留休眠配置;仅presigned使用所选直链。上传、multipart 和后端 I/O 继续使用存储 Endpoint,CNAME 配置独立。实现与升级
negate条件,通用表单据此控制地址可见性和必填;缺失值与 JSONnull均不匹配否定条件。后端默认规则与前端条件保持相同语义,同步所有调用方及生成 SDK。match;补充配置、签名目标、API 往返、模式切换和 Playwright 回归。m20261103_000001_cos_download_delivery只对缺少download_delivery且下载地址非空的 COS 配置写入custom_origin,覆盖保存策略、远端目标及延迟清理快照。显式模式不覆盖,运行时不推断模式;支持幂等执行、事务回滚和 down 迁移。alibaba_oss.rs条件初始化及格式对齐;基于已合入 feat(storage): support Alibaba OSS Type A CDN download delivery #694 的 master。验证
Related: #693, #697
Summary by CodeRabbit