Skip to content

fix(skins): add safety check for uninitialized bags db in guild bank - #99

Open
Xurkon wants to merge 1 commit into
Ascension-Addons:mainfrom
Xurkon:fix/guildbank-nil-db-crash
Open

fix(skins): add safety check for uninitialized bags db in guild bank#99
Xurkon wants to merge 1 commit into
Ascension-Addons:mainfrom
Xurkon:fix/guildbank-nil-db-crash

Conversation

@Xurkon

@Xurkon Xurkon commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds a safety check for the Bags module database (B.db) in the Guild Bank skin.

The issue

In some scenarios (likely due to the Guild Bank UI loading early on Ascension), the GuildBankFrame_Update hook fires before the ElvUI Bags module has fully initialized its database. This lead to a Lua error: ...GuildBank.lua:129: attempt to index field 'db' (a nil value).

The Fix

  • Wrapped the logic that depends on B.db (such as showBindType check and UpdateSlotAppearance) in a conditional if B.db then ... end.
  • This prevents the UI from crashing during initial load while ensuring skinning functionality resumes once the module is ready.

@Xurkon Xurkon closed this Jan 27, 2026
@Xurkon
Xurkon deleted the fix/guildbank-nil-db-crash branch January 27, 2026 01:34
@Xurkon
Xurkon restored the fix/guildbank-nil-db-crash branch January 27, 2026 01:34
@Xurkon Xurkon reopened this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant