Repository navigation
[fix] Fix streaming dataset chunking logic - #193
Merged
Merged
Conversation
Signed-off-by: dodatboii <zhangyixiang9@huawei.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
0oshowero0
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
chunk_batch_fnslices payloads bymicro_batch_size, but splits metadata evenly usingBatchMeta.chunk(num_splits). These boundaries can differ when the batch size is not divisible by the micro-batch size.For example, 10 samples with
micro_batch_size=4produce payload batches of[4, 4, 2], while metadata is split into[4, 3, 3]. This misaligns sample data and metadata.Change
Slice
BatchMetawith the same[start:end]boundaries used for the payload.