Repository navigation
feat(core): semantic archive preflight before target access (NEXT-33) - #112
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
happinessisreal
force-pushed
the
codex/bounded-archive-export
branch
from
October 31, 2026 05:28
8afd442 to
d9ff528
Compare
happinessisreal
force-pushed
the
codex/semantic-archive-preflight
branch
from
October 31, 2026 05:28
a020eb9 to
275c379
Compare
happinessisreal
force-pushed
the
codex/bounded-archive-export
branch
from
October 31, 2026 12:00
d9ff528 to
2f17ce8
Compare
happinessisreal
force-pushed
the
codex/semantic-archive-preflight
branch
from
October 31, 2026 12:00
275c379 to
f241145
Compare
happinessisreal
force-pushed
the
codex/bounded-archive-export
branch
from
October 31, 2026 12:12
2f17ce8 to
7dfdf5f
Compare
happinessisreal
force-pushed
the
codex/semantic-archive-preflight
branch
from
October 31, 2026 12:13
f241145 to
95b5138
Compare
- set Unix 0600/0700 during exclusive creation via OpenOptionsExt/DirBuilderExt - reject pre-existing scratch paths and avoid create_dir_all for private roots - reuse Windows ACL restriction with fail-closed cleanup - cleanup guard AutoRemoveFile removes newly owned files unless committed - separate serialization from path ownership via Write-based writer
- use iterative dependency-first traversal with explicit visiting/done states - verify commit signatures, address/project and dependency availability during walk - retain bounded addresses/metadata rather than retaining payload bytes - collect scoped object keys and stream read/validate one payload at a time - enforce max_commits, max_objects, max_frame_bytes and max_total_bytes in ArchiveWriter - test deep histories, shared subgraphs, exact byte limits, corrupt rows, and large payloads
happinessisreal
force-pushed
the
codex/bounded-archive-export
branch
from
October 31, 2026 12:48
7dfdf5f to
c061809
Compare
- add async semantic preflight using disposable LocalRepository to validate complete typed states, recovery and same-file merge evidence - complete preflight before creating, opening, or upgrading destination repository - route archive import and both offline verifier entry points through semantic preflight - reject invalid typed structures, non-state roots, and false recovery/merge evidence - test absent target stays absent and existing target stays unchanged on invalid archive
happinessisreal
force-pushed
the
codex/semantic-archive-preflight
branch
from
October 31, 2026 12:49
95b5138 to
f215a54
Compare
ArefinAlter
changed the base branch from
codex/bounded-archive-export
to
main
November 3, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements NEXT-33: semantic verification before touching the target.
LocalRepositoryin the staging directory to validate complete typed reconstructions, recovery plans, and same-file merge evidence using existingimport_objects/import_commitvalidators.archive-import.engine-cli archive-verifyandengine-cli repo archive-verify) run through full semantic verification without opening or modifying target repository databases.Checks Performed
task lint: cleantask test: 82 targets, 1514 passed, 0 failed, 4 ignoredtask docs: cleanopenapi.yaml: unchanged