Repository navigation
feat: a healer who can remove the debuff hears the dispel instead of the defensive - #82
Merged
Merged
Conversation
Data.lua: 23 rows changed, none added or removed. Shivan Punisher Demonic Frenzy loses its opener (support fell just under half), Chitigoth Insidious Aura bar 10s -> 8s, Overgrown Hydra Lightmaw Beams follow-up channel now verified, Brutok Head Bash hits 3 -> 2.5, damage/hits filled for six rows, the rest are held counters catching up. Traits.lua: Chitigoth channel 8s, Living Venom co-presence with 263109.
Head Bash hits sat at a median of 2.5 between a 1-target and a 5-target hump and flipped across the AOE line every sync; hits now need to clear it by 0.5. An opening at 49.3% support dropped Demonic Frenzy's opener; an anchored opening now needs 48% to stay and 52% to come back. Damage on a row that had none needs 5 samples, because the payload window books any hit of the caster: Ethereal Shade got TANK from 3 hits over 775 casts. Data.lua rebuilt: 17 rows changed instead of 23.
…the defensive Defensive debuff rows now carry the debuff's dispel type from client data. When it lands on a healer who knows a dispel for that type, the aura sound says "dispel magic" (or poison, curse, disease) instead of "defensive". Damage dealers, tanks and healers without that dispel still hear the defensive, and a healer gets nothing new on rows that never called healers. One sound per aura as before. Six rows have a dispel type; Living Bomb (Magic) is the only one that calls healers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Living Bomb in Ruby Life Pools became dispellable (Magic) with today's client data. Two can be up at once, so whoever carries one still needs a defensive. The healer is the exception, because they can remove their own.
dispel(Magic, Poison, Curse or Disease) from the client's spell data. Six rows have one. Living Bomb is the only one that also calls healers.test.lua and test_core.lua: OK. Not checked in game yet: needs a Ruby Life Pools key on a healer with Living Bomb landing on them.