Repository navigation
Regenerate the workflow onto xmsconan job (xmsconan 2.30.0) - #203
Merged
Merged
Conversation
Every leg installs xmsconan[ci]>=2.30.0,<3 and calls `xmsconan job build`, `job package`, `job deploy` and `job lint` instead of spelling the same steps out in YAML. What the template used to interpolate -- the matrix filter, the wheel and artifacts directories, the repair platform, the archive name -- the tools now read from build.toml and this job's environment. Three action-driven steps go with it. get-git-tag, set-env and branch-name existed to compute a version and a channel that the tools read from GITHUB_REF_NAME themselves, and the `conan cache save` step folds into `job deploy --cache-archive`. Secrets move from job-level env onto the steps that use them, so the pinned third-party actions and the artifact uploads no longer run with the Conan and devpi credentials in their environment. Note one settings-side change: AQUAPI_URL_DEV is read as a repository *variable* now rather than a secret, and defaults to the public dev index when unset. Generated, not hand-written -- `xmsconan_ci build.toml`.
Supersedes the closing note on this branch's previous commit, which said AQUAPI_URL_DEV is read as a repository *variable* now rather than a secret. That was true of 2.30.0 and it is the half of this branch worth correcting before it merges: the org secret this repository has always used would have stopped being read, and nothing would have said so. As of 2.30.1 the wheel upload reads both names, in this order -- the *variable* AQUAPI_URL_DEV, then the *secret* of the same name, then the built-in public dev index. The existing secret keeps working untouched. A non-empty variable wins over it; an empty variable does not, and falls through. The step also sets AQUAPI_URL_SOURCE from the same operands in the same order and echoes it before uploading. The URL itself cannot answer "which of the three supplied this": the built-in default is byte-identical to the org secret's value, and GitHub masks by value rather than by the name a value was read under, so the upload target renders `***` whichever source won. The source label matches no secret, so it is never masked and the deploy log names the source directly. Every install line moves to xmsconan[ci]>=2.30.1,<3 with it. Generated, not hand-written -- `xmsconan_ci build.toml`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates
.github/workflows/XmsGrid-CI.yamlfrombuild.tomlwith xmsconan 2.30.0, which collapses each job's steps onto thexmsconan jobcommands. Generated file: the change belongs to xmsconan's templates, not to this repo, and nothing here was hand-edited.What changed
xmsconan[ci]>=2.30.0,<3and runsxmsconan job build,job package,job deployandjob lintinstead of inline YAML. The matrix filter, the wheel and artifacts directories, the repair platform and the archive name are read frombuild.tomland the job environment.get-git-tag,set-envandbranch-nameaction steps are gone. They computed a version and a channel that the tools now read fromGITHUB_REF_NAMEthemselves. The separateconan cache savestep folds intojob deploy --cache-archive.env:onto the steps that use them, so the pinned third-party actions and the artifact uploads no longer run with the Conan and devpi credentials in their environment.Verification
Branch pipeline on this commit: all 15 legs green — https://github.com/Aquaveo/xmsgrid/actions/runs/34404966126
Macos/Linux/Windows across Debug and Release and py3.10/3.13/3.14, plus Flake Project.
Not yet exercised: the tag-gated deploy steps (
job deploy --wheels-only,job deploy --conan-only --from-cache). Tagging 9.1.2 after this merges is what covers them.One settings-side change
AQUAPI_URLis now read from the repository or organization variableAQUAPI_URL_DEV, not from a secret of that name, and falls back tohttps://public.aquapi.aquaveo.com/aquaveo/dev/when unset. This repo currently defines no Actions variables. If that URL lives in an org secret today, add it as a variable before the 9.1.2 tag, or the wheel upload will quietly target the default index instead.Doc impact
None in this repo. The job commands are documented in xmsconan
docs/USAGE.mdsection 10.4.