Repository navigation
Updated version - #27
Merged
Merged
Updated version #27
Conversation
Use --exclude-example to skip only the native examples for zig versions affected by ziglang/zig#23576, instead of omitting all examples. Ports pq-code-package/mlkem-native#1931. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Adds a zig-0.17 entry to the compiler matrices, sourced from nixpkgs-unstable, and drops zig 0.14 from ci.yml (still covered in legacy-compilers). zig 0.17 fixes ziglang/zig#23576 (CPU-feature predefines such as __AVX2__ being dropped in assembler-with-cpp mode), so we now also test the native backends and examples with it. The ABI check is skipped: on AArch64 it passes -march=armv8-a+simd and -march=armv8.4-a+sha3, which zig rejects since it parses -march as a CPU name. Ports pq-code-package/mlkem-native#1931. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Wycheproof regenerated the ML-DSA FIPS 204 edge-case vectors (C2SP/wycheproof@20b25694). - Resolves #1464 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
State in API-CONVENTIONS.md and mldsa_native.h that buffers passed to the same function must not overlap, document that the C code assumes constant-time 32x32->32 and 32x32->64 multiplication, and exclude the Armv8.1-M backend and the debug code from the CBMC claim in the README, as in mlkem-native. Ports pq-code-package/mlkem-native#1935. The SOUNDNESS.md change is not ported: mldsa-native's SOUNDNESS.md defers to mlkem-native's analysis, which now includes it. - Resolves #1463 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Add bug report and feature request issue forms adapted from mlkem-native. - Ports pq-code-package/mlkem-native#1693 - Resolves #1455 Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.