Repository navigation
Warn on mostly dark screenshots but let it pass for now - #12014
Merged
Merged
Conversation
…ng set; rename Warnings - test.yml: the screenshot-ok marker ignores the 'window is mostly dark' warning (any other remark about the window or screenshot still counts) - publish-pr-screenshot.yml: the heading '**Warnings:**' of the test result comment is now '**Suggestions for improving the AppImage:**' (and the check that mentions the upstream owner uses it) - AGENTS.md updated Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mostly dark screenshot alone no longer keeps screenshot-ok from being set; rename "Warnings"
Two changes to the test result:
screenshot-okis set even if the only remark about the screenshot is that the window is mostly dark (test.yml). Any other remark (mostly empty,may show an error message,not in English, or an error) still keeps it from being set; the dark window is still reported in the comment. Checked on sample logs: clean and dark-only give the marker; dark + error message, empty, dark + empty and error do not.**Warnings:**of the test result comment is now**Suggestions for improving the AppImage:**(publish-pr-screenshot.yml). The check that mentions the upstream account on warnings or name remarks uses the new heading, so its behaviour is unchanged. AGENTS.md updated.Old comments keep the old heading; nothing parses it besides that check.
actionlintis clean.Generated by Claude Code