Skip to content

Warn on mostly dark screenshots but let it pass for now - #12014

Merged
probonopd merged 1 commit into
masterfrom
claude/dark-screenshot-ok
Nov 14, 2026
Merged

probonopd merged 1 commit into
masterfrom
claude/dark-screenshot-ok

Conversation

@probonopd

@probonopd probonopd commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

A mostly dark screenshot alone no longer keeps screenshot-ok from being set; rename "Warnings"

Two changes to the test result:

  1. screenshot-ok is set even if the only remark about the screenshot is that the window is mostly dark (test.yml). Any other remark (mostly empty, may show an error message, not in English, or an error) still keeps it from being set; the dark window is still reported in the comment. Checked on sample logs: clean and dark-only give the marker; dark + error message, empty, dark + empty and error do not.
  2. The heading **Warnings:** of the test result comment is now **Suggestions for improving the AppImage:** (publish-pr-screenshot.yml). The check that mentions the upstream account on warnings or name remarks uses the new heading, so its behaviour is unchanged. AGENTS.md updated.

Old comments keep the old heading; nothing parses it besides that check.

actionlint is clean.


Generated by Claude Code

…ng set; rename Warnings

- test.yml: the screenshot-ok marker ignores the 'window is mostly dark'
  warning (any other remark about the window or screenshot still counts)
- publish-pr-screenshot.yml: the heading '**Warnings:**' of the test result
  comment is now '**Suggestions for improving the AppImage:**' (and the check
  that mentions the upstream owner uses it)
- AGENTS.md updated

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
@probonopd probonopd changed the title A mostly dark screenshot alone no longer keeps screenshot-ok from being set; rename "Warnings" Warn on mostly dark screenshots but let it pass for now Nov 14, 2026
@probonopd
probonopd merged commit cde9124 into master Nov 14, 2026
1 check passed
@probonopd
probonopd deleted the claude/dark-screenshot-ok branch November 14, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant