test(reading): run the same-file virtual dataset tests serially - #181
Merged
Apollo3zehn merged 1 commit intoAug 21, 2026
Merged
Conversation
TestUtils.PrepareTestFile drives the HDF5 C library, whose file tracking is process-global, so these tests fail intermittently against whatever else is creating a file at the same moment: System.IO.IOException : The process cannot access the file '/tmp/tmpXXXXXX.tmp' because it is being used by another process. Every other class that prepares a file through the C library already opts into SharedHdf5StateCollection. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VirtualDatasetSameFileTestsprepares its files throughTestUtils.PrepareTestFile, which drives the HDF5 C library, and that library's file tracking is process-global. Running the class in parallel with everything else therefore fails intermittently:Both tests in the class hit it, and it reproduced in roughly 2 of 8 full-suite runs here on
dev, on bothnet8.0andnet10.0. Each one passes when the class is run on its own.[Collection(SharedHdf5StateCollection.Name)]is what the other classes in this position already use —H5MemoryDriverTests,H5MemoryMappedFileDriverTests,AsyncDatasetReadTests,AsyncRegionReferenceTestsandFilterTestsall opt in. This class looks to have simply been missed.Sent separately from #179 and #180 because it is unrelated to either, but worth landing first: until it does, it will flake in their CI runs too.