Skip to content

docs(simplefin): list the payment thank-you patterns in CategoryRules.md - #189

Merged
AojdevStudio merged 2 commits into
mainfrom
fix/category-rules-doc-sync
Sep 24, 2026
Merged

AojdevStudio merged 2 commits into
mainfrom
fix/category-rules-doc-sync

Conversation

@AojdevStudio

Copy link
Copy Markdown
Owner

Main is red. #180 replaced the bare thank you card-payment pattern with three payment-shaped ones, and #186 added test_category_rules_doc_mirrors_the_public_table, which checks that CategoryRules.md lists every pattern. Each PR passed on its own; merged together, the doc still listed thank you and the test fails on main and on the release PR #184.

This updates the Credit Card Payment list and the card-payment paragraph to match the table. The paragraph also named a payment - thank pattern that doesn't exist in the code, so that claim is gone.

uv run pytest -m "not integration" passes locally (1,198 passed).

Made by Claude Opus 5.5 (1M context) in Claude Code.

🤖 Generated with Claude Code

AojdevStudio and others added 2 commits September 24, 2026 11:42
#180 replaced the bare 'thank you' pattern and #186 added a test that the
doc mirrors the table; merged together they left main red.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c622b7ce-b88c-4cb1-9308-176b2d18d82d

📥 Commits

Reviewing files that changed from the base of the PR and between fdf29c7 and 1b59a9d.

📒 Files selected for processing (1)
  • .claude/skills/TransactionSyncing/CategoryRules.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AojdevStudio
AojdevStudio merged commit 31c855b into main Sep 24, 2026
17 checks passed
@AojdevStudio
AojdevStudio deleted the fix/category-rules-doc-sync branch September 24, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant