Repository navigation
Stop Server tests failing at random on fresh CI runners - #229
Merged
Merged
Conversation
On a cold cache every Mongo-backed suite started the mongod download inside its own beforeAll. Parallel workers contended for the same lock and the download outlived the 10s hook timeout, so Server tests failed at random on fresh CI runners. A vitest globalSetup now fetches the binary once first.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Server tests failed on main after #228 with
Hook timed out in 10000msandCannot unlock file .../mongodb-binaries/8.2.6.lock. The tests themselves were fine. On a cold cache, which is every fresh CI runner, each Mongo-backed suite started the ~100 MBmongoddownload inside its ownbeforeAll. Parallel workers fought over the same lock, and the download took longer than the 10s hook timeout.Fix
server/test/global-setup.jscallsMongoBinary.getPath()once, through vitest'sglobalSetup, before any worker starts. Global setup has no hook timeout, so the suites only ever see a warm cache.Verification
HOME=<empty dir>) before the fix: 4 suites failed withHook timed out in 10000ms.npm run lintandnpm run test:coverage(warm cache) both pass.