Repository navigation
Share tab audio when screen sharing - #227
Merged
Merged
Conversation
The screen-share picker now offers tab/system audio. When picked, it is produced as a second 'screen' producer (stereo Opus, 128 kbps, DTX off, no voice processing) and played by RemoteAudio at master volume. Video-only shares and failed audio produces fall back to a video-only share.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Screen share sent video only. Sharing a tab with a video or music meant the room saw it but heard nothing.
Behavior
The share picker now offers Also share tab audio (and system audio for a whole screen in Chrome). When ticked, everyone in the call hears it. The presenter still hears the tab locally. Leaving it unticked gives the same video-only share as before.
Implementation
useMediasoup.shareScreenrequests display audio with echo cancellation, noise suppression and AGC off. A picked audio track is produced as a secondsource: 'screen'producer (stereo Opus, 128 kbps, FEC on, DTX off). Stopping the share closes both producers. If the audio produce fails, the share continues video-only.screen-source producers are already excluded from active-speaker detection and host mute, and the per-peer producer cap already allows mic + camera + screen video + screen audio.RemoteAudioplays each remote screen stream that carries audio, at master volume (not the presenter's mic slider). The stage share tile is now always muted so the audio is not played twice and does not depend on layout or pinning.Verification
npm run typecheck(shared, server, client, bot): exit 0npx vitest run: 260/260 passed, including new tests for audio produce, video-only fallback, failed audio produce, and RemoteAudio playback/volume