Repository navigation
Fix URL encoding of query strings in DSOURLField - #1311
Merged
pstokkink merged 1 commit intoOct 28, 2026
Merged
Conversation
DSOURLField used quote() with the default safe="/", which encoded the "=" and "&" of query strings into %3D and %26. This broke URL fields such as kaartlaagUrl and wmsCapabilitiesUrl. Characters with a meaning in the path/query (RFC 3986) are now left intact, including "%" so already encoded URLs are not encoded twice. Spaces still become %20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pstokkink
approved these changes
Oct 28, 2026
pstokkink
left a comment
pstokkink
left a comment
Contributor
There was a problem hiding this comment.
Gegeven dat deze class alleen urls serialized die uit de db komen, en niets doet met request urls enzo lijkt dit me SAFE genoeg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use with care: vibecoded
DSOURLField used quote() with the default safe="/", which encoded the "=" and "&" of query strings into %3D and %26.