Repository navigation
fix: explain why sql_execute refuses a query as a write, and stop misreading qualified columns
#1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandgupta42
wants to merge
58
commits into
main
Choose a base branch
from
fix/sql-readonly-guard-false-positives
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,534
−85
Open
fix: explain why sql_execute refuses a query as a write, and stop misreading qualified columns
#1812
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
2620cc0
fix: explain why `sql_execute` refuses a query as a write; stop misre…
anandgupta42 7f0ed7f
fix: keep `SELECT 1. INTO t` a write when exempting qualified columns
anandgupta42 b97438c
fix: tighten shell-residue detection, align `readSql`, keep SQL out o…
anandgupta42 4c2d954
fix: qualified columns are reads on SQL Server too; refusal reasons f…
anandgupta42 6a9d1c6
fix: refusal reasons keep file paths and pipe arguments out; a qualif…
anandgupta42 2101006
fix: shell-residue detection uses anchored patterns only; docs match …
anandgupta42 effb526
fix: dotted names of any length are columns, never after a number; te…
anandgupta42 b4e4daf
test: send a rule denial through `Effect.runPromise`, as the tool bri…
anandgupta42 de0937f
fix: name a plain write by its type on SQL Server; keep SQL text out …
anandgupta42 57c9b35
fix: word a pattern-scoped write denial as a rule, not read-only; ski…
anandgupta42 270bf82
fix: judge read-only from the rule in effect; cut parser messages to …
anandgupta42 9e8b968
fix: name SELECT INTO before batch keywords, hint quoted qualifiers, …
anandgupta42 01e219c
fix: query_from refusals carry the reason once; parser positions are …
anandgupta42 548ab80
fix: name the word a stricter sql_check list refuses; tidy parser det…
anandgupta42 e1af0c9
fix: pattern-only denies are not read-only; name SQL Server batches a…
anandgupta42 28e880b
fix: one reason helper names a stricter-list word only when it is the…
anandgupta42 65f502c
fix: keep ClickHouse dotted keywords strict; name only known keywords…
anandgupta42 bf8dc49
fix: trim the residue tail in linear time; report a missing SQL class…
anandgupta42 67f519e
fix: keep readSql strict for dotted statement words on ClickHouse, ma…
anandgupta42 d1b725a
test: the write corpus asserts write classification and a specific re…
anandgupta42 ef53fc9
fix: own next step for an unavailable classifier; one keyword source;…
anandgupta42 151e409
fix: refusals from sql_check, query_from and sql_materialize carry th…
anandgupta42 fa40acd
refactor: one constant for the unavailable-classifier next step
anandgupta42 b2466f9
fix: name hard-blocked statements in read-only refusals
anandgupta42 9aae937
docs: spaced qualifiers still ask, like quoted ones
anandgupta42 16c2cc2
fix: word unreadable quoted text neutrally (open or unsupported)
anandgupta42 ade0b00
fix: name a closed executable comment instead of asking to close a quote
anandgupta42 742003c
fix: name which statement is hard-blocked in read-only refusals
anandgupta42 f48e3d5
fix: detect executable comments from comment tokens, not raw text
anandgupta42 993e19e
fix: do not place a real hard block inside an unclosed quote
anandgupta42 162d1d9
fix: name the hard-block rule and explain hard blocks in every tool
anandgupta42 83b753f
fix: record the hard-block cause in the classifier itself
anandgupta42 6fb1ee4
fix: CLI denial wording, fixed-word hard-block labels
anandgupta42 b77eeec
fix: name the clearest write and the warehouse hint only where it helps
anandgupta42 da71cba
fix: one parse per dialect on denial; test the missing-parser path
anandgupta42 c52a33c
fix: streamline SQL refusal explanations and stabilize parser test
anandgupta42 6caa2a4
test: pin qualified keyword-named functions as calls; keep tests vali…
anandgupta42 bd397d8
fix: preserve SQL refusal telemetry classes and explain unsupported r…
anandgupta42 5cd4407
fix: name why a read cannot be embedded; a missing classifier is not …
anandgupta42 0b34a0b
refactor: one ordered check names why a read cannot be embedded
anandgupta42 cb887bf
fix: keep SQL Server XML .query() a read; hard blocks keep their own …
anandgupta42 aa3d5ce
fix: hard blocks keep the permission class; one SQL Server dialect ch…
anandgupta42 c8a3d47
fix: SQLite returns rows for comment-led reads; ClickHouse names shel…
anandgupta42 4feaf28
fix: keep the SQLite driver unchanged; name ClickHouse redirects only…
anandgupta42 d06aa2b
fix: name ClickHouse redirects on any read, including SHOW and DESCRIBE
anandgupta42 29fe53f
fix: quote names in refusal hints the way the dialect does
anandgupta42 94a878d
fix: refusal hints quote names with brackets on SQL Server and backti…
anandgupta42 050301b
fix: case-correct quoting hints on ClickHouse, Snowflake and Oracle
anandgupta42 c730117
fix: pattern-rule refusals name the allowed patterns; hints fit the a…
anandgupta42 67ceaaa
fix: honest write-clause hints; pattern names stay out of telemetry; …
anandgupta42 d0585f0
fix: name only sql_execute_write's own allow/ask patterns
anandgupta42 2645542
fix: name only rule patterns still in effect after the last catch-all…
anandgupta42 b1a702f
fix: ClickHouse pipe rule needs a flagged command; escape backslashes…
anandgupta42 01d0a8c
fix: numbers never read as dotted names in hints; residue refusals sk…
anandgupta42 81d9e4e
fix: residue is a flag from explainWrite; leading-dot decimals are nu…
anandgupta42 54ad4d6
fix: data_diff names the refused input; a parenthesized SELECT is tol…
anandgupta42 14e92f7
fix: a read starting with a parenthesis gets advice that holds for se…
anandgupta42 7746915
fix: the parenthesis reason no longer repeats the closing advice
anandgupta42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.