Repository navigation
fix: run --max-turns charges completed steps, not retried attempts
#1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandgupta42
wants to merge
20
commits into
main
Choose a base branch
from
fix/turn-budget-counts-finished-steps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+689
−56
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
db553c8
fix: `run --max-turns` charges completed steps, not retried attempts
anandgupta42 b2aa0bc
test: real-processor retry-cap test; fix header comment wrap
anandgupta42 f3d86f7
test: the attached fake answers the soft time-budget reminder without…
anandgupta42 e44eab2
refactor: drop the side-effect-free step-start wrapper; one compactio…
anandgupta42 60ee544
test: drop the wall-clock assertion from the time-budget bound test
anandgupta42 a1b6100
test: a post-budget compaction step is never charged or stopped; name…
anandgupta42 e70fc3e
docs: name --time-budget as the bound for repeated overflow-and-compa…
anandgupta42 dd48417
fix: `--max-turns` also stops runs whose step attempts never finish
anandgupta42 c468841
fix: the attempt-backstop message no longer claims the turn limit was…
anandgupta42 47c6c8a
fix: a step cut short by context overflow still costs its turn
anandgupta42 d1f4524
fix: overflows rejected before a step starts count toward the attempt…
anandgupta42 e8f89b6
fix: the attempt backstop also stops a committed echo, and skips the …
anandgupta42 134e8aa
fix: a pre-step overflow after the turn limit stops the run; one abor…
anandgupta42 d22b2d7
refactor: drop the attempt backstop; keep charging a step cut short b…
anandgupta42 3065db0
fix: an idle session closes the open step; unit tests record each att…
anandgupta42 0cbcee0
test: the endless-attempts test requires attempts after the initial b…
anandgupta42 72137c3
fix: a retry closes the failed attempt; help says harness turns count…
anandgupta42 60bb2b9
test: the attached fake counts retries per assistant step, like the p…
anandgupta42 efb9752
fix: a step that compaction replaces is charged regardless of event o…
anandgupta42 db16e07
test: share the fake's compaction-step and assistant-message helpers
anandgupta42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.