Repository navigation
feat: finops_databricks_savings and finops_snowflake_savings: read-only warehouse savings checks #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shreyastelkar
wants to merge
56
commits into
main
Choose a base branch
from
feat/databricks-savings-tool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: finops_databricks_savings and finops_snowflake_savings: read-only warehouse savings checks #1762
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
d0f9aef
feat: `finops_databricks_savings`: Databricks SQL warehouse savings
shreyastelkar 3cbff41
feat: `finops_databricks_savings`: idle clusters, jobs on all-purpose…
shreyastelkar 022b90c
fix: hand core the job inventory's trigger; window, limit and blank-n…
shreyastelkar 44ed9d8
fix: keep the warehouse findings when core refuses cluster or job facts
shreyastelkar bcb5af2
feat: read every workspace the connection's system tables cover
shreyastelkar 3052130
docs: savings tool header, refusal text and example match every-works…
shreyastelkar c253ac7
test: the live savings check must succeed; docs: only cluster and job…
shreyastelkar c4511d2
fix: assessment mode: the packaged CLI contacts only the customer's w…
shreyastelkar 19d5cdd
docs: state the savings cost window as the queries and core compute it
shreyastelkar ffd8be6
fix: assessment mode also covers sign-in lookups, remote config, plug…
shreyastelkar 3301c32
fix: assessment mode keeps the well-known token for substitution; fla…
shreyastelkar 6e0c010
fix: assessment mode keeps local sign-out cleanup and makes no active…
shreyastelkar 4e3799c
fix: assessment mode installs no npm plugin in the plugin loader
shreyastelkar cd5ed30
docs: serverless SQL warehouses get the over-sized check
shreyastelkar db658f4
fix: assessment mode switches core's own telemetry off before the sav…
shreyastelkar 41fce2a
fix: assessment mode silences altimate-core's own telemetry for every…
shreyastelkar 2ab21ec
fix: assessment mode silences core before `mcp serve` returns from th…
shreyastelkar 73683e1
test: the middleware test passes the assessment flag and core switch,…
shreyastelkar 6d1ee99
feat: the savings check runs only with `confirm: true`, and stops aft…
shreyastelkar a3338f7
fix: the savings check's limit covers connecting and the run's time b…
shreyastelkar a80b2f1
fix: the jobs savings check finds jobs through the compute their task…
shreyastelkar b468212
fix: job facts skip rows with no job, keep every task, and count job …
shreyastelkar 48545c1
Merge origin/main into feat/databricks-savings-tool
shreyastelkar 20b89b3
fix: close a Databricks statement whose fetch fails, and test the mis…
shreyastelkar 16d0af7
feat: the Snowflake driver cancels on `cancelAfterMs` or abort, and s…
shreyastelkar db06540
feat: `finops_snowflake_savings`, the Snowflake warehouse savings check
shreyastelkar ade5a6b
fix: Snowflake savings counts restart gaps in whole elapsed seconds
shreyastelkar 89567af
feat: the Databricks savings check reports how many workspaces it che…
shreyastelkar f59833a
docs: assessment mode claims no Altimate contact only for the savings…
shreyastelkar 7400c9b
fix: a Snowflake query with no cloud services credits keeps its compu…
shreyastelkar 211c191
fix: Databricks and Snowflake cancel an aborted statement without a d…
shreyastelkar f5ef7a1
fix: the savings checks start no work after a stop and read the rate …
shreyastelkar 7187e47
fix: assessment mode leaves the user's workspace skills and rules in …
shreyastelkar 78dc8e3
fix: Databricks waits for the close on ordinary queries; savings outp…
shreyastelkar a75b3ed
fix: a client-side query timeout abandons the statement; only a stop …
shreyastelkar f7d74f2
Merge origin/main into the savings tools branch
shreyastelkar 0ea9473
fix: read savings evidence in the shape altimate-core returns
shreyastelkar bef2d65
fix: ask permission before a savings check queries the warehouse
shreyastelkar 9cfce64
fix: ask about the connection a savings check runs on
shreyastelkar cf767f8
fix: name the connection in the savings check prompt
shreyastelkar 4b445f6
fix: say who decides a savings run on each surface
shreyastelkar bd5ed71
fix: stop before asking when a savings check has no connection
shreyastelkar bbf2252
test: pin the CLI read permissions with the two savings checks
shreyastelkar 3321cfa
fix: share the savings prompt and check the warehouse path first
shreyastelkar 01d42ca
refactor: pick the default Databricks connection with the shared path…
shreyastelkar 1985848
fix: keep the savings checks out of the CLI read permissions
shreyastelkar 8a421ac
test: refuse the savings checks over the MCP adapter itself
shreyastelkar e86fbeb
fix: keep a same-day predecessor's usage off a recreated Snowflake wa…
shreyastelkar e5a9de6
fix: give a renamed Snowflake warehouse its usage when its old name i…
shreyastelkar d35bf98
fix: give each Snowflake warehouse id to the listed warehouse it fits
shreyastelkar 68d1d45
test: cover each rule that decides a Snowflake warehouse id's owner
shreyastelkar 4716b9c
test: drive the MCP savings refusal through the server flag, and cove…
shreyastelkar 26028a2
test: make the Snowflake id tie test fail when the larger-id rule is …
shreyastelkar 6e299f8
perf: group Snowflake fact rows by warehouse id once
shreyastelkar 67363b9
docs: name the larger-id tie-break in the Snowflake id ownership comment
shreyastelkar c5d497d
refactor: derive the Snowflake per-id row maps from the one source list
shreyastelkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.