Skip to content

feat: /altimate-feedback drafts a GitHub issue and files it only after you confirm - #45

Draft
hkaltai wants to merge 14 commits into
mainfrom
feat/feedback-command
Draft

hkaltai wants to merge 14 commits into
mainfrom
feat/feedback-command

Conversation

@hkaltai

@hkaltai hkaltai commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

What

/altimate-feedback <what happened> drafts a GitHub issue for this repository from the user's words plus a few facts the plugin already knows, shows the exact title and body, and creates the issue only after /altimate-feedback --confirm.

The command is a mod command (like /defer or /dbt-show). It is not named /altimate-code:feedback or /feedback: Claude Code's own /feedback takes that name over a plugin's, and a mod cannot register a namespaced name (both tried live).

Behaviour

  1. /altimate-feedback <text>: shows the draft (title, body). Nothing is sent; gh and the browser are not started. Without text it says how to start.
  2. /altimate-feedback --confirm: creates exactly what was shown.
    • gh installed and signed in (gh auth status): gh issue create --repo AltimateAI/altimate-claude-plugin --title … --body-file - (body on stdin), with --label feedback only when the repository has that label. Prints the created URL.
    • Otherwise (not installed, not signed in, or gh failing): prints and opens (macOS open, Linux xdg-open) a prefilled issues/new?title=…&body=… link, URL-encoded and kept under 7000 characters; a longer body is cut on a character boundary with a note. The plugin never signs in.
    • A gh call that times out is not retried (the issue may exist).
  3. --cancel discards the draft; a new description replaces it; the draft is in memory only and ends with the session. A description that merely contains the word --confirm is a description.

What is attached, and what is removed

  • Attached: plugin version, altimate-code version and binary name (never the path), Claude Code version, OS, dbt-core / adapter / Python versions when the dbt doctor has run (versions parsed out of the doctor's checks, never its text), and the plugin's on/off settings (allow-listed).
  • --with-error (opt in) adds the kind of the last plugin error: only what a fixed list recognises in it (error type such as Database Error, errno / SQLSTATE codes, the plugin's own $.process.run-style host-call names, a few fixed phrases) is kept, at the moment the error happens; the message itself is never stored or filed, so no path, SQL, relation, model or column name or secret can come with it.
  • The description keeps the user's own words, minus the dbt profile's secret values, tokens, passwords, credentials and home-folder paths (secrets are cut from the whole text before it is cut to length; a quoted home path is cut whole, an unquoted one with spaces in a folder name is cut when a separator follows the space).
  • ALTIMATE_FEEDBACK_DRY_RUN=1 makes --confirm print the gh command (or the link) and stop; used for the live check below.

Files

  • hooks/feedback.ts: payload builder, redaction, link builder, send, command.
  • hooks/last-problem.ts: the in-memory last error and the doctor-version parser (separate so the dbt helpers can record into it without an import cycle).
  • hooks/features/index.ts, hooks/dbt-mods.tsx, hooks/usage.ts: record the last error, read the doctor's versions, export pluginVersion.
  • README section, CHANGELOG under [Unreleased] (version not bumped), PRIVACY.md section.

No "Report" button on the failure band: a button can submit a prompt but not pre-fill the composer, so it would not be cheap or consistent.

Tests

  • claude plugin test plugins/altimate-code: 1317 pass, 1 fail: the known flake "a dbt call that starts while another call reads its artifact" (also fails on main). 54 new tests in hooks/feedback.test.tsx: payload fields, redaction (secrets, credential keys, profile values, home paths, error-kind allow-list, truncation), link encoding and truncation, gh present / label present or missing / gh missing / not signed in / create failing / create timing out, dry run, no gh or browser call and no issue before --confirm, --confirm with no draft or after --cancel, double confirm creates once, the sent title and body equal the shown ones.
  • claude plugin validate --strict .: passed. bash tests/*.sh: all pass.

Live check

Real interactive Claude Code 2.1.329 (claude --plugin-dir plugins/altimate-code) in a scratch copy of a dbt project, with ALTIMATE_FEEDBACK_DRY_RUN=1. No issue was created on the real repository during testing.

  • Draft shown with the home path and password=… in the description redacted; --confirm printed the gh issue create --repo AltimateAI/altimate-claude-plugin --title … --body-file - command and stopped.
  • With gh off PATH: --confirm printed the encoded prefilled link and nothing else.

Conflicts with open PR #44 (fix/hands-on-findings)

git merge-tree of this branch against it: clean (no conflicts).

🤖 Generated with Claude Code

… after you confirm

Builds the issue from the description plus plugin, altimate-code, Claude Code,
OS, dbt and settings facts (and, with --with-error, the last plugin error,
redacted), shows the exact title and body, and creates it with gh issue create
or a prefilled new-issue link after --confirm.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@gitguardian

gitguardian Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
40187247 Triggered Generic Password 8c44c81 plugins/altimate-code/hooks/feedback.test.tsx View secret
40737365 Triggered Generic Password 8c44c81 plugins/altimate-code/hooks/feedback.test.tsx View secret
40738749 Triggered Generic Password 3e05fb4 plugins/altimate-code/hooks/feedback.test.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

…n /feedback shadows a plugin command of that name

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@hkaltai hkaltai changed the title feat: /altimate-code:feedback drafts a GitHub issue and files it only after you confirm feat: /altimate-feedback drafts a GitHub issue and files it only after you confirm Nov 20, 2026
hkaltai and others added 12 commits November 20, 2026 22:18
…ct the description before cutting it, and drop a draft that is discarded while it is built

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…iption instead of cutting it, clear the shown draft while a replacement is built, and redact JSON-escaped home paths

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ng quote, and clear the shown draft before a refused replacement

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…lues, ~/ paths and parenthesised folder names

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nd blank lines included

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…es whole

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t keys whole

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and a last unquoted one, whole

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…, and treat doubled quotes in a quoted connection-string password as part of it

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…en and cut them in one pass, so no rule can hide another's match

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…times

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… of times

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant