Repository navigation
test: cost and runs tests pass with both features on #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1c80847
test: cost and runs tests pass with both features on
hkaltai e06c39b
fix: a session folder that is never answered no longer uses up the bu…
hkaltai eb451aa
test: the cost gate waits at most 80 ms for a session folder that is …
hkaltai 5ee89b3
fix: a session folder that cannot be read in time is no known project…
hkaltai 52baaa5
fix: a session folder that stays unreadable is a different unknown pr…
hkaltai 64afffa
fix: an unreadable session folder starts no estimate and refuses the …
hkaltai 4820695
fix: a lookup of the session folder that is not answered while an est…
hkaltai 897f917
fix: a lookup of the session folder that goes unanswered refuses the …
hkaltai e187620
fix: a lookup of the session folder that goes unanswered refuses at o…
hkaltai 056d443
fix: an unreadable session folder is no project change; one lookup bu…
hkaltai 9d7bf77
merge origin/main
hkaltai 71844b9
fix: a folder lookup that fails, once a folder has been seen, refuses…
hkaltai 381e9a9
fix: every failed or unanswered folder lookup refuses the scan; the d…
hkaltai 961577c
fix: a line refused for its unreadable folder keeps the over-limit an…
hkaltai 702c5d5
fix: the unreadable-folder refusal records nothing for a project that…
hkaltai 2bb03ed
fix: an over-limit estimate in hand when the folder is lost still hol…
hkaltai 1c1b129
refactor: one refusal helper that records the hold, drops the unreach…
hkaltai ff811ae
fix: an over-limit answer kept for an unreadable-folder refusal is vi…
hkaltai 60db684
fix: a folder lookup that fails outright falls back to the session ro…
hkaltai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUGGESTION: only one of the five lookups in this loop reaches the guard added in this PR
For
dbt run -s ordersthe session-folder lookups are: runs'bashRewrite(1), cost's gate at 224 (2),estimateWithinat 653 (3),startWhenIdleat 442 (4), the re-check at 689 (5), and the gate's second read at 264 (6). On the pre-change code a stall at 2 is denied at cost.tsx:234, at 4 bystartWhenIdle's existingisUnknowncheck (444), at 5 by therunning.dircomparison at 689, and at 6 bychangedDeny(302), so cases 2, 4, 5 and 6 deny without this change, and case 2 repeats the test at line 218. Only case 3 covers the newif (isUnknown(here)) return 'pending'. Because the assertion is justdenytoBeDefined, it cannot tell those denial reasons apart - and case 3 currently accepts the "still being estimated" message for a command whose estimate never started. Assert the exact message per case (or thatestimates/startedstay empty) and drop the cases that duplicate existing coverage; the numbering also silently depends on how many features call$.session.cwd().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 056d443: the loop over lookups 2 to 6 now asserts the refusal says the folder could not be read, so each stalled lookup is pinned to the unreadable guard and not to the 'still being estimated' path. (Lookup 1 is not cost's: a stall there does not reach this feature.) The remaining guards for each lookup are the
look.lostchecks in gate, estimateWithin and startWhenIdle.