Repository navigation
fix: shared fixes so the dbt Power User feature PRs merge in any order #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6305b87
fix: shared tests answer every feature's CLI call with nothing to rep…
hkaltai 99da11a
fix: a tool call that fails without an answer shows the first line of…
hkaltai 0d76fef
fix: a long run of blank lines before a shell command is read in line…
hkaltai b9231c9
fix: the feature index test drives the features through an engine tha…
hkaltai 6d4e6da
test: a separate check that no feature fails in any phase, with every…
hkaltai 590a869
fix: a cut-off JSON answer shows only stderr; any line break ends the…
hkaltai 267104a
test: complete the fake process.run result in the tool-chain test
hkaltai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // For tests: what each data tool a feature asks for answers when there is nothing to report. A test's | ||
| // fake CLI answers these first, so the calls it records are its own and a feature that is built finds a | ||
| // project with nothing to say, whichever features are built. | ||
| const NOTHING_TO_REPORT: Record<string, Record<string, unknown>> = { | ||
| docs_share_comments: { threads: [] }, | ||
| dbt_health: { success: true, insights: [] }, | ||
| dbt_defer_state: { success: true, enabled: false, mode: 'none' }, | ||
| dbt_cost_estimate: { supported: false, adapter: 'none' }, | ||
| dbt_run_results: { found: false }, | ||
| // The docs feature shows a coverage line for any successful answer and passes over one that isn't, silently. | ||
| dbt_docs_coverage: { success: false }, | ||
| } | ||
|
|
||
| /** The answer of the `altimate tool run <name>` in `argv` when `name` is one a feature asks for; null for any other command. */ | ||
| export function nothingToReport(argv: readonly string[]): { exitCode: number; stdout: string; stderr: string } | null { | ||
| const [, command, sub, name] = argv | ||
| const metadata = command === 'tool' && sub === 'run' && name !== undefined ? NOTHING_TO_REPORT[name] : undefined | ||
| if (!metadata) return null | ||
| return { exitCode: 0, stdout: JSON.stringify({ status: 'ok', output: '', metadata }), stderr: '' } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.