Repository navigation
feat: project health: new DataPilot issues on changed models, in the band, with an optional push gate #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
51050d5
feat: project health: new DataPilot insights on the models Claude cha…
hkaltai 45c795f
fix: project health band updates
hkaltai f3d172b
Merge feat/pu-mods-foundation into feat/health
hkaltai fd340eb
fix: project health push gate holds on an unfinished or failed check,…
hkaltai a21c1c8
fix: push gate reads heredocs, here-strings and unbalanced substituti…
hkaltai 53bea56
fix: a heredoc belongs to the command it follows, and a shift is not …
hkaltai 40deecc
fix: the health push gate sees a push behind a leading redirect, skip…
hkaltai beb0583
fix: the health check skips models inside an installed dbt package th…
hkaltai 3538583
fix: the health push gate sees a push behind a leading input redirect…
hkaltai d4020f9
fix: an input redirect's file is read, not written, and quoted digits…
hkaltai 2b0ce1c
fix: the health hooks resolve symlinked folders through the engine, s…
hkaltai 73660d7
fix: health commits a check only once every edited file's folder is r…
hkaltai 00f366a
fix: a health check from before a session restart writes nothing whil…
hkaltai de85ff6
fix: the health feature clears a status part an earlier process left,…
hkaltai c26b3f0
Merge remote-tracking branch 'origin/feat/pu-mods-foundation' into fe…
hkaltai c40f3b9
test: health's feature tests on top of the foundation's registration …
hkaltai 6a872c6
Merge commit '4c8add5238faa61034cf3a21037c50d77eb9db32' into feat/health
hkaltai 00c9161
fix: the health push gate answers inside the tool chain's deadline, a…
hkaltai f7ad7ad
fix: the health push gate counts its earlier work against the chain's…
hkaltai 5d1f513
fix: a deleted shared schema file counts every model, those without a…
hkaltai 3cce2c0
fix: the health push gate measures its remaining wait after its last …
hkaltai 657293b
Merge remote-tracking branch 'origin/feat/pu-mods-foundation' into fe…
hkaltai cc4d687
fix: project health keeps the baseline when no schema file is named, …
hkaltai 59f84f2
fix: project health treats a result the engine cut at its size limit …
hkaltai f8104bd
docs: project health states what it cannot see of a shell's working f…
hkaltai eb08fe7
fix: project health settings and README say the check is live, a nest…
hkaltai a9adab2
Merge remote-tracking branch 'origin/main' into feat/health
hkaltai 4d2b7d5
Keep to health's own files: shared files match main; health bounds it…
hkaltai bbac474
test(health): pin the push gate's wait below the tool chain's phase d…
hkaltai ce2011c
fix(health): a model dropped from a schema file that still documents …
hkaltai 9962fac
fix(health): bound the whole push-gate decision, folder lookups inclu…
hkaltai 49266f7
Merge origin/main into feat/health
hkaltai 01378cb
fix(health): a comment no longer hides a push, a throwing clock drops…
hkaltai 5c13dd1
docs(health): state the late-baseline limit for a model dropped from …
hkaltai eb8d48c
fix(health): a relative file a Bash command writes is read from the s…
hkaltai ee73986
fix(health): a cd in the same Bash command is read from the folder th…
hkaltai f04ebc7
test(health): the push gate reads a relative edit from the shell's fo…
hkaltai 9b9b05a
test(health): pin the shell folder the push gate reads a relative edi…
hkaltai 1aa54d6
fix(health): the shell-folder lookup of a push is inside the gate's b…
hkaltai f352d99
fix(health): the shell folder noted before a command belongs to that …
hkaltai ee9b55a
Merge origin/main into feat/health
hkaltai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor (wording; Codex found it). This says a push is refused "while the project health check finds new issues". After a model change, the gate also refuses when the check failed, did not finish within the 4 s wait, or has no baseline yet, even with zero issues (health.tsx:728). The README row at line 144 has the same gap. Adding one clause would match the code. It does not block, because the refusal text tells the user why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed; the plugin.json and README wording will state that the push is also refused when the check failed, timed out or has no baseline. Follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already matches at main: plugin.json and the README row say the push is also held while the check cannot run or has not finished.