Repository navigation
Release/kiro extension 0.2.0 - #43
Merged
Merged
Conversation
electron-builder only looks for electron-builder.{yml,json,js,cjs,ts}, so
electron-builder.config.cjs was never read. Every pack and dist build fell
back to the defaults: the app came out as doraemon-desktop.app, without
the window probe, and with the whole project directory (863 MB, .env
included) packed into app.asar.
Passing --config fixes it. The packaged app is Doraemon.app again, with a
29 MB app.asar and Contents/Resources/bin/doraemon-companion, so the
installed app can walk on other windows too.
The config still copies .env into Contents/Resources on purpose (the main
process reads it from there), so a build carries the keys in that file.
Doraemon now stands on, rides and climbs other apps' windows in desktop mode, and every sprite is rebuilt as a sharp 2x master at one scale and baseline.
With the usual layout of a near-maximised window right under the menu bar, 0.2.0 found nothing to stand on, so Doraemon never touched any window. Now: - a top edge with no room above it can still be hung from: he flies up with the Take-copter, grips it, moves along it, rides the window when it moves and drops when it closes, moves away or gets covered - switching apps sends him to the new active window about half the time, and trips he starts himself pick the active window most of the time - let go of him at the top of a window and he grabs it; with his feet a little below a title bar he stands on it - a pinned coding reaction waits until he is on his feet instead of freezing him mid-trip or striking a pose while he hangs off something; the hosts show the travel animation until then Hosts: - the desktop app's ceiling is now the work area's top, so he is no longer drawn half behind the macOS menu bar there - the Kiro companion's window cannot go above the menu bar, so near the top the sprite moves up inside the stopped window and the bubble moves below him; before, he was drawn up to 112 px below where he was Checked on macOS with a near-maximised test window: both hosts hung from its top edge, stood on it once it moved down, and rode it back up.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.