Repository navigation
ci(kiro-extension): attach VSIX files to a GitHub Release - #38
Merged
Merged
Conversation
The workflow only produced upload-artifact bundles, which expire after 90 days and require a GitHub login to download. That is fine for CI plumbing and useless as a distribution channel, so a tagged build now creates a real Release and attaches every platform's VSIX to it. The Release is created as a draft. Each platform attaches its own file the moment it is packaged, keeping the per-platform independence the rest of the workflow is built around, and the universal job flips the draft public as its last step. Since that job only runs once all four platforms succeeded, reaching it is the signal the release is complete: if any platform fails the release stays a draft, visible to maintainers and not to users. All four jobs race to create the same Release. Three of them are expected to lose, so the create is tolerant of failure and followed by a short poll, because the winner is not visible to the others instantly. Also spells out the environment-secret trap in the publish guard. A secret added under Settings > Environments is only visible to a job declaring `environment:`, which this job deliberately does not, since an environment carrying protection rules would gate every pull request build too. The old message said "add it in repository settings" and gave no hint why an already-added secret was arriving empty. Verified: YAML parses, every run: block parses under bash -n, and the release-notes heredoc was executed to confirm it dedents to flush-left markdown so the platform table renders. The tag-gated steps themselves are unexercised until a real tag is pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow only produced upload-artifact bundles, which expire after 90 days and require a GitHub login to download. That is fine for CI plumbing and useless as a distribution channel, so a tagged build now creates a real Release and attaches every platform's VSIX to it.
The Release is created as a draft. Each platform attaches its own file the moment it is packaged, keeping the per-platform independence the rest of the workflow is built around, and the universal job flips the draft public as its last step. Since that job only runs once all four platforms succeeded, reaching it is the signal the release is complete: if any platform fails the release stays a draft, visible to maintainers and not to users.
All four jobs race to create the same Release. Three of them are expected to lose, so the create is tolerant of failure and followed by a short poll, because the winner is not visible to the others instantly.
Also spells out the environment-secret trap in the publish guard. A secret added under Settings > Environments is only visible to a job declaring
environment:, which this job deliberately does not, since an environment carrying protection rules would gate every pull request build too. The old message said "add it in repository settings" and gave no hint why an already-added secret was arriving empty.Verified: YAML parses, every run: block parses under bash -n, and the release-notes heredoc was executed to confirm it dedents to flush-left markdown so the platform table renders. The tag-gated steps themselves are unexercised until a real tag is pushed.