Repository navigation
fix(kiro-extension): unbreak Windows CI, handle macOS quarantine - #37
Merged
Merged
Conversation
The win32-x64 job failed on a test defect, not a product one. path.join follows the host separator rather than the stubbed process.platform, so a Windows runner resolved bin\darwin-arm64\doraemon-companion while the assertion looked for forward slashes. Assertions now compare on a single separator. The resolver itself was always correct. Revived a dead test branch while here. The "existing hooks are left alone" check was guarded by `typeof installAgentHooks === 'function'`, but that symbol is internal to the bundle and never exported, so the check had been silently skipped on every platform. It now drives the real path a user hits, a second activate() with the hook files already on disk, and asserts nothing is rewritten. macOS ships downloaded binaries with com.apple.quarantine, which kills the companion before it prints a single byte (measured: 32 bytes clean, 0 when quarantined). The extension now detects the flag and offers to clear it, only on explicit consent, since stripping it silently would defeat the control it exists to provide. Declining falls back to window mode rather than leaving the user with a pet that never appears. Verified: typecheck, build, 34 smoke checks, 4 quarantine checks against a real quarantined binary. Windows and Linux running the pet for real remain unverified, no runner on hand for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The win32-x64 job failed on a test defect, not a product one. path.join follows the host separator rather than the stubbed process.platform, so a Windows runner resolved bin\darwin-arm64\doraemon-companion while the assertion looked for forward slashes. Assertions now compare on a single separator. The resolver itself was always correct.
Revived a dead test branch while here. The "existing hooks are left alone" check was guarded by
typeof installAgentHooks === 'function', but that symbol is internal to the bundle and never exported, so the check had been silently skipped on every platform. It now drives the real path a user hits, a second activate() with the hook files already on disk, and asserts nothing is rewritten.macOS ships downloaded binaries with com.apple.quarantine, which kills the companion before it prints a single byte (measured: 32 bytes clean, 0 when quarantined). The extension now detects the flag and offers to clear it, only on explicit consent, since stripping it silently would defeat the control it exists to provide. Declining falls back to window mode rather than leaving the user with a pet that never appears.
Verified: typecheck, build, 34 smoke checks, 4 quarantine checks against a real quarantined binary. Windows and Linux running the pet for real remain unverified, no runner on hand for that.