Repository navigation
fix(kiro-extension): guard the first Open VSX publish - #35
Merged
Merged
Conversation
Two things that would have failed or silently misfired on the first release. Publishing into a namespace that does not exist fails outright, and the namespace had never been claimed. `ovsx create-namespace` now runs first. It is idempotent, so the first release needs no manual web step and later ones are unaffected. An "already exists" response is treated as success; anything else stops the publish with the registry's own message rather than a generic failure. The tag names the release but the version comes from package.json, and nothing checked they agreed. Tagging kiro-extension-v0.2.0 with a manifest still on 0.1.0 would have published 0.1.0 under a misleading tag, and Open VSX does not allow replacing a published version. The publish path now refuses to run when GITHUB_REF_NAME disagrees with the manifest, before anything is uploaded. Verified locally: packaging without --publish is unchanged; a mismatched tag is rejected before any network call; a matching tag proceeds to the namespace step and stops there on a bad token with "Invalid access token".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things that would have failed or silently misfired on the first release.
Publishing into a namespace that does not exist fails outright, and the namespace had never been claimed.
ovsx create-namespacenow runs first. It is idempotent, so the first release needs no manual web step and later ones are unaffected. An "already exists" response is treated as success; anything else stops the publish with the registry's own message rather than a generic failure.The tag names the release but the version comes from package.json, and nothing checked they agreed. Tagging kiro-extension-v0.2.0 with a manifest still on 0.1.0 would have published 0.1.0 under a misleading tag, and Open VSX does not allow replacing a published version. The publish path now refuses to run when GITHUB_REF_NAME disagrees with the manifest, before anything is uploaded.
Verified locally: packaging without --publish is unchanged; a mismatched tag is rejected before any network call; a matching tag proceeds to the namespace step and stops there on a bad token with "Invalid access token".