Use Triple overload for target machine creation#1323
Closed
cervoliu wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates llvm_util::optimize_module to construct the LLVM target machine using the non-deprecated llvm::Triple overload of codegen::createTargetMachineForTriple, avoiding deprecation warnings that break builds when -Werror is enabled.
Changes:
- Replace the deprecated
StringRef-based call (ModuleTriple.str()) with thellvm::Tripleoverload (ModuleTriple) when creating the target machine.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the non-deprecated
llvm::Tripleoverload ofcodegen::createTargetMachineForTripleinllvm_util::optimize_module.Root Cause
Current LLVM headers deprecate the
StringRefoverload ofcreateTargetMachineForTriplein favor of theTripleoverload. Alive2 builds with-Werror, so the deprecation warning stops the build inllvm_util/llvm_optimizer.cpp.Impact
This keeps Alive2 building against current LLVM without changing target machine selection behavior.
Validation
cmake --build buildctest --test-dir build --show-onlyshowed no configured CTest tests in this build tree.