Repository navigation
sprint13/develop #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sprint13/develop #22
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
f228861
Добавление в БД таблицы Отзывов(reviews)
LyutovSergey e714324
Добавление в БД таблицы Отзывов(reviews)
LyutovSergey ad22d46
Добавление в БД таблицы Отзывов(reviews)
LyutovSergey cd6b435
add-reviews ver 1.0
LyutovSergey 80fe1bc
add-reviews ver 1.0
LyutovSergey 5880c1b
add-reviews ver 1.0
LyutovSergey f65b591
add-reviews ver 1.1
LyutovSergey 27159ea
Merge pull request #6 from AleksOBM/add-reviews
LyutovSergey dd320ad
Добавление сущности события + доработка UserService и FilmService на …
milayadasha 916ec8f
feat: Implement film recommendation system
Darya346 0794ac6
Доработка ReviewService и решение конфликтов
milayadasha 0dbf16c
trigger tests after changing base branch
Darya346 32a9779
fix: add empty line before getRecommendations for checkstyle
Darya346 ae14ec3
Решение ошибок тестов (убрала неиспользуемый импорт)
milayadasha 0958a90
fix: force remove all trailing whitespaces
Darya346 1782a06
fix: remove trailing whitespace in UserService
Darya346 4109667
Merge pull request #7 from AleksOBM/add-recommendations
Darya346 c8ce8b8
Merge branch 'develop' into add-feed
milayadasha 17781d9
Решение конфликтов при мёрже
milayadasha b6c4c14
Merge pull request #8 from AleksOBM/add-feed
milayadasha 0d56fc7
Модернизация метода, который возвращает популярные фильмы. Добавлены …
milayadasha 71675e1
Merge pull request #11 from AleksOBM/add-most-populars
milayadasha 5d5816a
Создать основные классы, расставить todo
AleksOBM 046673b
Отключить JPA
AleksOBM b7d0e40
Добавить таблицы в БД,
AleksOBM f163c26
Добавить логику обновления и удаления режиссеров, и сортировку фильмо…
AleksOBM 2bb2201
Исправить readme
AleksOBM a44c77a
Добавить @Autowired
AleksOBM 7ae6495
Merge pull request #9 from AleksOBM/add-director
AleksOBM 18df2d1
ver 1.0 Добавлена возможность получать общих с другим пользователем ф…
LyutovSergey 5baa904
ver 1.1 обновление после внесения изменений в film
LyutovSergey 433de15
Merge pull request #12 from AleksOBM/add-common-films
LyutovSergey d824d6e
Добавить функциональность для удаления фильма и пользователя по идент…
AleksOBM 90d5a75
Add search
Darya346 f9dc750
trigger search tests
Darya346 ad6eed3
Merge pull request #13 from AleksOBM/add-remove-endpoint
AleksOBM a53baf3
Merge branch 'develop' into add-search
Darya346 fac6ffb
fix: resolve all checkstyle issues
Darya346 ecaa10a
fix: fix checkstyle
Darya346 7602f02
fix: resolve checkstyle empty line issues
Darya346 a20a4de
fix: resolve checkstyle
Darya346 a9e27e5
checkstyle
Darya346 5513208
Merge pull request #14 from AleksOBM/add-search
Darya346 22faeb1
В сущности Event поле id заменила на eventId
milayadasha 409ba1c
Merge pull request #16 from AleksOBM/add-feed
milayadasha 0b9dda8
В метод getTopByFilters добавлен директор
milayadasha 6c3ed03
Merge pull request #17 from AleksOBM/fix-most-popular
milayadasha a0361a1
Исправить валидацию имени пользователя
AleksOBM b61c976
Исправить текст ошибки при отсутствии режиссеров
AleksOBM fad5d92
Исправить ошибку отсктствия записи в базу при обновлении жанров и реж…
AleksOBM ff81dcc
Исправить ошибку при которой старый режиссер или жанр остается, если …
AleksOBM 83d64a1
Убрать unused import
AleksOBM 5f22178
Добавить проверку имени пользователя при получении события пользователя
AleksOBM b53306b
Рефакторинг и подготовка к первому ревью
AleksOBM 47657a0
Отправка на первое ревью
AleksOBM c11817b
Исправить мелкие баги и доработать readme
AleksOBM c4491a5
fix: исправлены замечания в getRecommendations
Darya346 33681bb
fix: remove unused import in ReviewService
Darya346 d981d3e
Merge pull request #23 from AleksOBM/add-recommendations
Darya346 402c5ea
Отправить на второе ревью
AleksOBM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/main/java/ru/yandex/practicum/filmorate/controller/DirectorController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package ru.yandex.practicum.filmorate.controller; | ||
|
|
||
| import jakarta.validation.Valid; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.web.bind.annotation.*; | ||
| import ru.yandex.practicum.filmorate.dto.DirectorDto; | ||
| import ru.yandex.practicum.filmorate.dto.request.create.DirectorCreateRequest; | ||
| import ru.yandex.practicum.filmorate.dto.request.update.DirectorUpdateRequest; | ||
| import ru.yandex.practicum.filmorate.service.DirectorService; | ||
|
|
||
| import java.util.Collection; | ||
|
|
||
| @RequestMapping("/directors") | ||
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class DirectorController { | ||
| private final DirectorService directorService; | ||
|
|
||
| @GetMapping | ||
| public Collection<DirectorDto> getAllDirectors() { | ||
| return directorService.getAllDirectorDtos(); | ||
| } | ||
|
|
||
| @GetMapping("/{directorId}") | ||
| public DirectorDto getDirectorById(@PathVariable Integer directorId) { | ||
| return directorService.getDirectorDtoById(directorId); | ||
| } | ||
|
|
||
| @PostMapping | ||
| public DirectorDto createDirector(@RequestBody @Valid DirectorCreateRequest directorRequest) { | ||
| return directorService.create(directorRequest); | ||
| } | ||
|
|
||
| @PutMapping | ||
| public DirectorDto updateDirector(@RequestBody @Valid DirectorUpdateRequest directorRequest) { | ||
| return directorService.update(directorRequest); | ||
| } | ||
|
|
||
| @DeleteMapping("/{directorId}") | ||
| public void deleteDirector(@PathVariable Integer directorId) { | ||
| directorService.delete(directorId); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вау))