Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom mods now have selectable slots above the hovered skin carousel, with the selected mod's preview shown on its targeted skin art. Switching from mod A to B, deselecting, or leaving champion select restores the appropriate original art.
Supersedes #342, updated on current main with its review fixes preserved. Preview handling supports video elements with source children, layered backgrounds, and mods targeting multiple skins. The HistoricMode popup is suppressed only while the selected slot is visible; failed champion-alias lookups retry, and inactive phases stop preview scans. Mods responses carry the authoritative backend selection so unlocking/relocking or loading mid-session restores the selected slot and preview without an extra state broadcast.
This replacement also fixes stale lock state after reconnecting and refreshes slot names and thumbnails when metadata changes without changing mod identifiers. Regression tests exercise the backend snapshot and real plugin logic through simulated bridge events and DOM updates. No live League client was tested.
Validation:
git diff --checkpassed.