Repository navigation
fix(party-ui): release pending controls when the bridge disconnects - #383
Merged
Alban1911 merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing or restarting Rose while Party Mode was adding a friend left the plugin's panel locked: its close button and Done control stayed unavailable. Losing the connection during enable/disable also left the toggle disabled. Requests made while disconnected were queued and could unexpectedly execute after reconnection.
Track the pending action and restore the controls when the bridge connection closes. Keep the panel open, return the friend's token to its input and show a retry message. User mutations now require an open connection and are never queued; reconnecting requests current state without replaying an action. State confirmation settles a pending enable/disable, while an add remains locked until its reply, disconnection or party mode being disabled. Normal replies still release the controls. The new messages use the existing English translation fallback.
Validation:
node --test test/party_ui_reconnect.test.cjs: 5 pass; all 5 fail against the base plugin.git diff --checkpass.Validation does not include a live League client or establish a fix for issue #374.