Repository navigation
fix(party): bound connection token decoding - #382
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting a compressed party token could allocate hundreds of megabytes on Rose's plugin bridge event loop. Decoding used unbounded zlib inflation and accepted payloads longer than the defined token layout. A local example expanded to about 200 MiB and was accepted as a token.
Bound token text before decoding, limit decompression output to one byte beyond the largest valid payload, and require a complete stream without trailing data. Accept only the exact v1/v2 payload sizes. Existing valid v1/v2 tokens, optional
ROSE:prefixes, omitted base64 padding and acceptance of older tokens remain supported. Truncated streams were already rejected by zlib; the new checks additionally enforce complete consumption and exact payload lengths.Validation:
python -m unittest party.tests.test_token_limits: 9 pass; 4 fail against base146f7986.git diff --checkpass.