Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an installer previously regenerated the tracked
assets/icon.icofrom the PNG on every run, modifying the checkout and potentially replacing the intended icon. Preserve an existing ICO; generate from the PNG only when the ICO is missing. Keep the existing conversion-error handling and copy-to-dist behavior.Validation: four temporary-root tests cover preserving existing bytes, generating a missing ICO, conversion failure without an ICO, and using an existing ICO without Pillow. The preservation regression fails against the pre-change implementation; all four pass with this change. Compiler invocation is mocked in these tests. All 330 Python tests passed in the current combined worktree; Ruff 0.16.8 error-only checks and
git diff --checkpassed.Source overlap: #365 also changes
scripts/create_installer.pyfor compiler discovery; its diff does not address ICO regeneration. This narrow change remains based on main. #366 changes the Inno script and does not touch this builder.