Repository navigation
fix(installer): preserve unrelated root files and remove duplicate app entry - #380
Merged
Alban1911 merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choosing an existing shared folder (for example
D:\Games) as Rose's installation directory previously caused uninstall to recursively delete everything in that folder. Remove the install root only when empty; retain Inno's tracked-file removal and the existing explicit application-subdirectory, startup-task, and IFEO cleanup.Let Inno maintain the single AppId-based Installed Apps entry instead of writing an additional
Uninstall\Roseentry. On install/uninstall, remove the legacy duplicate only when its recorded installation directory, display name, and publisher match this installation. Entries for a different location or owner are left intact.Validation: three installer safety regressions pass; the root-deletion and duplicate-registration regressions fail against the pre-change source. The actual Inno Setup 6 compiler successfully compiled the script in a temporary stub tree; the resulting installer was never executed. All 330 Python tests passed in the current combined worktree; Ruff 0.16.8 error-only checks and
git diff --checkpassed. Registry behavior is checked statically; no live registry changes or install/uninstall execution occurred.Source overlap: #366 also changes
installer.issto offer AppData retention and patcher backup, but retains the recursive install-root deletion. This change is based on main and addresses root safety/duplicate Apps registration without duplicating those features. #365 changes installer build tooling rather than this script.