Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After restarting Rose, saved category mods (VFX, UI, voiceover and related categories) were not automatically restored unless the selector was opened. The history loader returns per-category keys, but injection checked for the removed legacy
otherkey before reading those categories.Handle category history before the single-mod lookup. Keep existing explicit selections ahead of saved choices. Correct the shared legacy
otherwriter to replace the category lists with grouped, deduplicated paths, clear stale categories and avoid duplicating every path underothers. Map/font/announcer history and direct category writes retain their behavior.Validation: the restoration regression fails against
146f7986. With restoration enabled but before correcting the writer, three real-persistence roundtrip tests and three writer tests fail (stale entries and duplicateotherspaths). All ten focused tests now pass, including partial missing history followed by a second restore with exactly one overlay mod, mixed categories, all missing categories and explicit choice priority. Package suites with temporary LOCALAPPDATA: threads 52 tests, utils 56 tests pass. Ruff E9/F63/F7/F82 andgit diff --checkpass. Tests mock injection and use temporary mod folders and real temporary history files; they do not establish a fix for issue #374.