Repository navigation
fix(mods): preserve unreadable skin metadata and roll back failed imports - #378
Merged
Alban1911 merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient read failure on a valid skin-mod manifest previously looked like an empty manifest, so the next import/target update replaced existing targets and display aliases. If metadata saving failed after extraction, the imported folder was also left behind despite the reported failure.
Require readable existing target metadata before writing, including the legacy manifest fallback. Roll back only the newly promoted skin import folder when registration fails; preserve existing mods and metadata. Missing manifests and valid legacy imports continue to work.
Validation: four regression cases fail against
146f7986; all nine manifest tests pass with this change. Coverage includes valid JSON with a transient PermissionError, import rollback, unreadable legacy metadata, missing manifests and valid legacy imports.python -B -m unittest discover -s injection/tests -t .: 61 tests pass with temporary LOCALAPPDATA. Ruff E9/F63/F7/F82 andgit diff --checkpass. New tests use temporary files and mocks.